Return invalid username error instead of unknown error #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuki-YuXin
reviewed
Jan 25, 2024
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/errors/SignInErrors.kt
Show resolved
Hide resolved
rmccahill
reviewed
Jan 25, 2024
...c/test/java/com/microsoft/identity/nativeauth/NativeAuthPublicClientApplicationJavaTest.java
Show resolved
Hide resolved
SammyO
requested changes
Jan 25, 2024
msal/src/main/java/com/microsoft/identity/nativeauth/NativeAuthPublicClientApplication.kt
Show resolved
Hide resolved
SammyO
requested changes
Jan 25, 2024
msal/src/main/java/com/microsoft/identity/nativeauth/statemachine/errors/SignUpErrors.kt
Show resolved
Hide resolved
SammyO
reviewed
Jan 25, 2024
...c/test/java/com/microsoft/identity/nativeauth/NativeAuthPublicClientApplicationKotlinTest.kt
Show resolved
Hide resolved
Yuki-YuXin
approved these changes
Jan 26, 2024
rmccahill
approved these changes
Jan 26, 2024
SammyO
approved these changes
Jan 26, 2024
SammyO
reviewed
Jan 28, 2024
| return@withContext SignUpError( | ||
| errorType = ErrorTypes.INVALID_USERNAME, | ||
| errorMessage = "Empty or blank username", | ||
| correlationId = "UNSET" //TODO use null correlation id here and in other places in this file instead of UNSET |
There was a problem hiding this comment.
Why this TODO? Why can't be left UNSET?
There was a problem hiding this comment.
This was old TODO when correlationId was nullable in your PR. This has now been removed.
SaurabhMSFT
added a commit
to AzureAD/microsoft-authentication-library-common-for-android
that referenced
this pull request
Jan 28, 2024
Corresponding PR in MSAL Repo : AzureAD/microsoft-authentication-library-for-android#2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the username is empty or malformed then a InvalidUsername error is returned instead of UnknownError
Corresponding PR in common repo: AzureAD/microsoft-authentication-library-common-for-android#2297