Add InvalidError for NativeAuth #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaurabhMSFT
changed the title
SaurabhMSFT
added
the
No-Changelog
SaurabhMSFT
added
the
Skip-Consumers-Check
rmccahill
approved these changes
Jan 25, 2024
GBakolas
approved these changes
Jan 25, 2024
SammyO
reviewed
Jan 25, 2024
| @@ -72,4 +72,15 @@ interface INativeAuthCommandResult { | |||
| open val correlationId: String = DiagnosticContext.INSTANCE.threadCorrelationId, | |||
| open val errorCodes: List<Int>? = null | |||
| ) | |||
|
|
|||
| data class InvalidUsername( | |||
There was a problem hiding this comment.
Where is this class returned? I'm not seeing updates to the Controller or anywhere else.
SammyO
reviewed
Jan 25, 2024
| @@ -72,4 +72,15 @@ interface INativeAuthCommandResult { | |||
| open val correlationId: String = DiagnosticContext.INSTANCE.threadCorrelationId, | |||
| open val errorCodes: List<Int>? = null | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
If we're checking for blank usernames in the SDK interface, then we can remove the ArgUtils.validateNonNullArg(username, "username") from the respective request classes right?
SammyO
approved these changes
Jan 26, 2024
SaurabhMSFT
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
Jan 29, 2024
If the username is empty or malformed then a InvalidUsername error is returned instead of UnknownError Corresponding PR in common repo: AzureAD/microsoft-authentication-library-common-for-android#2297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding PR in MSAL Repo : AzureAD/microsoft-authentication-library-for-android#2020