Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(armclient): removing 429 sdk retries in favor of controller retries #13

Merged
merged 5 commits into from
Nov 8, 2023
Merged

chore(armclient): removing 429 sdk retries in favor of controller retries #13

merged 5 commits into from
Nov 8, 2023

Conversation

Bryce-Soghigian
Copy link
Collaborator

Fixes #

Description
Karpenter is a reconciler, and will retry the scale up or delete request if it fails. Also note it only retries on 429 and some other options by default.

Instead of retrying with SDK we should retry with karpenter, and if we need additional retry flexiblity with backoff for throttling aim to get this change into karpenter core.

How was this change tested?
Scale up scale down
make az-presubmit
e2etests

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

Bryce-Soghigian
Bryce-Soghigian commented Nov 8, 2023
View reviewed changes
Copy link
Collaborator Author

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@Bryce-Soghigian Bryce-Soghigian changed the title chore(armclient): removing 429 sdk retries in favor of provider retries chore(armclient): removing 429 sdk retries in favor of controller retries Nov 8, 2023
matthchr
matthchr previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but we should make sure we have test coverage that demonstrates that the controller-runtime loop-based backoffs do the right thing here. Do we?

pkg/utils/opts/armopts.go Show resolved Hide resolved
@Bryce-Soghigian Bryce-Soghigian merged commit 19d06fd into main Nov 8, 2023
5 checks passed
@tallaxes tallaxes deleted the bsoghigian/removing-sdk-retries branch November 8, 2023 20:15
Bryce-Soghigian added a commit that referenced this pull request Dec 1, 2023
@Bryce-Soghigian
Revert "Merge pull request #13 from Azure/bsoghigian/removing-sdk-ret…
12b7ca2 
…ries"

This reverts commit 19d06fd, reversing
changes made to 9bfdf16.
tallaxes pushed a commit that referenced this pull request Dec 1, 2023
@Bryce-Soghigian
Revert "Merge pull request #13 from Azure/bsoghigian/removing-sdk-ret…
b58470a 
…ries" (#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthchr matthchr matthchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bryce-Soghigian @matthchr