Skip to content

Commit

Permalink
Revert "Merge pull request #13 from Azure/bsoghigian/removing-sdk-ret…
Browse files Browse the repository at this point in the history
…ries" (#54)
  • Loading branch information
Bryce-Soghigian authored Dec 1, 2023
1 parent 45a0eb5 commit b58470a
Showing 1 changed file with 16 additions and 5 deletions.
21 changes: 16 additions & 5 deletions pkg/utils/opts/armopts.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package opts

import (
"net/http"
"time"

"github.com/Azure/azure-sdk-for-go/sdk/azcore/arm"
"github.com/Azure/azure-sdk-for-go/sdk/azcore/policy"
Expand All @@ -34,11 +35,21 @@ func DefaultArmOpts() *arm.ClientOptions {

func DefaultRetryOpts() policy.RetryOptions {
return policy.RetryOptions{
// MaxRetries specifies the maximum number of attempts a failed operation will be retried
// before producing an error.
// The default value is three. A value less than zero means one try and no retries.
// See Reference here: https://github.com/Azure/azure-sdk-for-go/blob/v61.4.0/sdk/azcore/policy/policy.go#L73
MaxRetries: -1,
MaxRetries: 20,
// Note the default retry behavior is exponential backoff
RetryDelay: time.Second * 5,
// TODO: bsoghigian: Investigate if we want to leverage some of the status codes other than the defaults.
// the defaults are // StatusCodes specifies the HTTP status codes that indicate the operation should be retried.
// A nil slice will use the following values.
// http.StatusRequestTimeout 408
// http.StatusTooManyRequests 429
// http.StatusInternalServerError 500
// http.StatusBadGateway 502
// http.StatusServiceUnavailable 503
// http.StatusGatewayTimeout 504
// Specifying values will replace the default values.
// Specifying an empty slice will disable retries for HTTP status codes.
// StatusCodes: nil,
}
}

Expand Down

0 comments on commit b58470a

Please sign in to comment.