Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Psl bug 9334 #1425

Merged
merged 6 commits into from
Oct 21, 2024
Merged

fix: Psl bug 9334 #1425

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9fdf562
"Updated error messages in chat history API to provide more user-frie…
Somesh-Microsoft Oct 17, 2024
4feb999
Fix typos in error messages in chat history API
Somesh-Microsoft Oct 21, 2024
a4ba955
Merge branch 'main' into PSL_BUG_9334
Somesh-Microsoft Oct 21, 2024
4ecdc9a
fix: Exception error
Somesh-Microsoft Oct 21, 2024
70f3dcd
Merge branch 'PSL_BUG_9334' of https://github.com/Roopan-Microsoft/ps…
Somesh-Microsoft Oct 21, 2024
165d6b8
fix: Update White Space
Somesh-Microsoft Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions code/backend/api/chat_history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ async def list_conversations():
return (jsonify(conversations), 200)

except Exception as e:
logger.exception("Exception in /list")
return (jsonify({"error": str(e)}), 500)
logger.exception("Exception in /list" + str(e))
return (jsonify({"error": "Error While listing historical conversations"}), 500)


@bp_chat_history_response.route("/history/rename", methods=["POST"])
Expand Down Expand Up @@ -152,8 +152,8 @@ async def rename_conversation():
return (jsonify(updated_conversation), 200)

except Exception as e:
logger.exception("Exception in /rename")
return (jsonify({"error": str(e)}), 500)
logger.exception("Exception in /rename" + str(e))
return (jsonify({"error": "Error renaming is fail"}), 500)


@bp_chat_history_response.route("/history/read", methods=["POST"])
Expand Down Expand Up @@ -217,8 +217,8 @@ async def get_conversation():
200,
)
except Exception as e:
logger.exception("Exception in /read")
return (jsonify({"error": str(e)}), 500)
logger.exception("Exception in /read" + str(e))
return (jsonify({"error": "Error while fetching history conversation"}), 500)


@bp_chat_history_response.route("/history/delete", methods=["DELETE"])
Expand Down Expand Up @@ -266,8 +266,8 @@ async def delete_conversation():
200,
)
except Exception as e:
logger.exception("Exception in /delete")
return (jsonify({"error": str(e)}), 500)
logger.exception("Exception in /delete" + str(e))
return (jsonify({"error": "Error while deleting history conversation"}), 500)


@bp_chat_history_response.route("/history/delete_all", methods=["DELETE"])
Expand Down Expand Up @@ -320,8 +320,8 @@ async def delete_all_conversations():
)

except Exception as e:
logger.exception("Exception in /delete")
return (jsonify({"error": str(e)}), 500)
logger.exception("Exception in /delete" + str(e))
return (jsonify({"error": "Error while deleting all history conversation"}), 500)


@bp_chat_history_response.route("/history/update", methods=["POST"])
Expand Down Expand Up @@ -412,8 +412,8 @@ async def update_conversation():
)

except Exception as e:
logger.exception("Exception in /update")
return (jsonify({"error": str(e)}), 500)
logger.exception("Exception in /update" + str(e))
return (jsonify({"error": "Error while update the history conversation"}), 500)


@bp_chat_history_response.route("/history/frontend_settings", methods=["GET"])
Expand All @@ -428,8 +428,8 @@ def get_frontend_settings():
)
return jsonify({"CHAT_HISTORY_ENABLED": chat_history_enabled}), 200
except Exception as e:
logger.exception("Exception in /frontend_settings")
return (jsonify({"error": str(e)}), 500)
logger.exception("Exception in /frontend_settings" + str(e))
return (jsonify({"error": "Error while getting frontend settings"}), 500)


async def generate_title(conversation_messages):
Expand Down
Loading