Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Psl bug 9334 #1425

Merged
merged 6 commits into from
Oct 21, 2024
Merged

Conversation

Somesh-Microsoft
Copy link
Contributor

Purpose

  • Cover exposes the internal error. This should not be surfaced to the UI.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Copy link

github-actions bot commented Oct 21, 2024

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/api
   chat_history.py21017715%24–28, 32–33, 35, 37, 44–47, 49, 51, 55–57, 63, 68–71, 76–78, 80–82, 85–88, 91, 94–95, 100, 102–104, 109–113, 116, 119–120, 122–123, 126–128, 131, 134–135, 145–149, 152, 154–156, 161–163, 165–166, 169, 172–173, 175–176, 179–181, 184, 188–189, 199, 204, 215, 219–221, 226–228, 230, 232, 235, 237–240, 249–251, 254, 257, 259, 268–270, 275–277, 279, 281, 284, 288–290, 292, 295–296, 302, 304, 309, 313, 322–324, 329–331, 333–335, 337–340, 343–345, 348, 351–353, 356, 360–362, 370, 376–377, 379, 381–382, 384, 391, 398, 400, 414–416, 421–424, 429–432, 436, 438, 443, 445–447, 454–457
TOTAL310991570% 

Tests Skipped Failures Errors Time
301 0 💤 0 ❌ 0 🔥 50.012s ⏱️

@Somesh-Microsoft Somesh-Microsoft changed the title Psl bug 9334 Fix : Psl bug 9334 Oct 21, 2024
@Somesh-Microsoft Somesh-Microsoft changed the title Fix : Psl bug 9334 fix: Psl bug 9334 Oct 21, 2024
@Somesh-Microsoft
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Somesh-Microsoft Somesh-Microsoft added this pull request to the merge queue Oct 21, 2024
Merged via the queue into Azure-Samples:main with commit a9997b0 Oct 21, 2024
6 checks passed
@Somesh-Microsoft Somesh-Microsoft deleted the PSL_BUG_9334 branch October 21, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants