Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement bb.js browser tests (karma) #696

Closed
wants to merge 2 commits into from

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Aug 20, 2023

--- This is a draft PR, please don't review ---

@TomAFrench
Copy link
Member

Heads up:

Note this will need to be migrated to Aztec packages with the script and merged there. We allow admin bypass for this repo but hope to only use that for release please (and nothing going forward once Aztec has release please)

#695 (comment)

@kevaundray
Copy link
Contributor

Right -- this should be migrated to aztec-packages and also linked to an issue/PR description explaining why we are making this change

@ludamad
Copy link
Collaborator

ludamad commented Aug 21, 2023

Note for completeness, if you find it useful you can develop it here, let me know if you need some CI turned on, but at the end there's a script in aztec-packages: ./scripts/migrate_barretenberg_branch.sh jb/bbjs-browser-tests-karma "feat: implement..."

@jonybur jonybur closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants