Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement bb.js browser tests (web-test-runner) #661

Closed
wants to merge 6 commits into from

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Aug 16, 2023

-WORK IN PROGRESS; DO NOT REVIEW-

Description

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@jonybur jonybur changed the title JB/Implement bb.js tests feat: implement bb.js tests Aug 16, 2023
@jonybur jonybur changed the title feat: implement bb.js tests feat: implement bb.js browser tests Aug 16, 2023
@kevaundray
Copy link
Contributor

This should be moved to aztec-packages as noted in the #696 -- just looking at the PR titles, I can't tell what the difference/relevance is between this and #696, so a PR description would be good

@jonybur jonybur changed the title feat: implement bb.js browser tests feat: implement bb.js browser tests (web-test-runner) Aug 21, 2023
@jonybur jonybur closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants