Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize existing names/descriptions and prevent new issues #160

Merged
merged 1 commit into from
Nov 30, 2023

Commits on Nov 30, 2023

  1. Sanitize existing names/descriptions and prevent new issues

    Since this is a diff against the old (pre-unit test) code, I cannot
    prove that this works, but I will be applying an analogous patch +
    unit tests against main here shortly.   This feels correct in that
    it will
    
    a) strip out the 'real' unit/faction/object number from the name.
    b) rebuild the name with the new set of legal characters (and reattach
    the unit/faction/object number)
    c) sanitize the descriptions to only the new set of legal characters on
    readin.
    d) prevent (via the change to islegal()) any new names or descriptions
    from containing the bogus characters.
    
    The non-allowed characters are now the set ()[]; instead of just
    () as before.
    jt-traub committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    f3ba359 View commit details
    Browse the repository at this point in the history