Tidy up dockerfile #210
Merged
Tidy up dockerfile #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving the COPY command under the apk command, the package installation no longer runs on every change
We should install pipenv before copying any files, as its outcome won't be changed by any file updates. Additionally, copying only the pipfiles in then running pipenv install before copying the rest of the project helps prevent rebuilds.
pip pulls down pre-compiled versions of all the required packages, so we don't need to build anything locally.
|
thanks for this @NotActuallyTerry! 🎉 |
primetheus
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rearranges & tidies up the Dockerfile to achieve a few things:
Testing locally, a fresh build now takes 7 seconds less (31s vs 38s) & uses less than 25% of the space (296MB vs 1.38GB)