Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default to empty back and front #90

Merged
merged 3 commits into from
Dec 20, 2023
Merged

fix: default to empty back and front #90

merged 3 commits into from
Dec 20, 2023

Commits on Dec 20, 2023

  1. fix: default to empty back and front 

    The problem we have is that some users who export tables get the crash
below:
> Command failed: /usr/bin/python3 /home/alemayhu/src/github.com/2anki/create_deck/create_deck.py /tmp/workspaces/<redacted>/deck_info.json /home/alemayhu/src/github.com/2anki/2anki.net/src/templates/ Traceback (most recent call last): File "/home/alemayhu/src/github.com/2anki/create_deck/create_deck.py", line 151, in fields = [card["name"], card["back"], ",".join(card["media"])] KeyError: 'back'
    @aalemayhu
    aalemayhu committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    ce2251a View commit details
    Browse the repository at this point in the history

  2. build: remove weird line in pylintrc 

    Hoping this fixes the build issue

> ImportError: cannot import name 'find_pylintrc' from 'pylint.config' (/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/pylint/config/__init__.py)
    @aalemayhu
    aalemayhu committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    f4efb1c View commit details
    Browse the repository at this point in the history

  3. build: disable false positives for pylint

    @aalemayhu
    aalemayhu committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    9782978 View commit details
    Browse the repository at this point in the history