Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default to empty back and front #90

Merged
merged 3 commits into from
Dec 20, 2023
Merged

fix: default to empty back and front #90

merged 3 commits into from
Dec 20, 2023

Conversation

aalemayhu
Copy link
Contributor

The problem we have is that some users who export tables get the crash
below:

Command failed: /usr/bin/python3 /home/alemayhu/src/github.com/2anki/create_deck/create_deck.py /tmp/workspaces//deck_info.json /home/alemayhu/src/github.com/2anki/2anki.net/src/templates/ Traceback (most recent call last): File "/home/alemayhu/src/github.com/2anki/create_deck/create_deck.py", line 151, in fields = [card["name"], card["back"], ",".join(card["media"])] KeyError: 'back'

The problem we have is that some users who export tables get the crash
below:
> Command failed: /usr/bin/python3 /home/alemayhu/src/github.com/2anki/create_deck/create_deck.py /tmp/workspaces/<redacted>/deck_info.json /home/alemayhu/src/github.com/2anki/2anki.net/src/templates/ Traceback (most recent call last): File "/home/alemayhu/src/github.com/2anki/create_deck/create_deck.py", line 151, in fields = [card["name"], card["back"], ",".join(card["media"])] KeyError: 'back'
Hoping this fixes the build issue

> ImportError: cannot import name 'find_pylintrc' from 'pylint.config' (/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/pylint/config/__init__.py)
Copy link

sonarcloud bot commented Dec 20, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@aalemayhu aalemayhu merged commit 1a52d58 into main Dec 20, 2023
5 checks passed
@aalemayhu aalemayhu deleted the fix/crash-in-table branch December 20, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant