Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for heimdall v2 init, new msg for updateParams #19

Merged
merged 27 commits into from
Oct 14, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
9a6caff
chg: remove validatorUpdates check
marcello33 Sep 4, 2024
23e44f9
add: enable VEs height
marcello33 Sep 4, 2024
9b6d15f
chg: make StakeKeeper public in gov
marcello33 Sep 4, 2024
5d19d6b
chg: better context for comment
marcello33 Sep 4, 2024
8a29e86
chg: revert public StakeKeeper in gov module
marcello33 Sep 5, 2024
4e54783
chg: enable VEs at block 1
marcello33 Sep 5, 2024
3e9bb00
chg: restore validatorUpdates check as WriteValidators has been imple…
marcello33 Sep 12, 2024
3320287
chg: replace eth with bor
marcello33 Sep 17, 2024
146235c
chg: install new comet version
marcello33 Sep 17, 2024
0a5eacb
chg: bump comet
marcello33 Sep 17, 2024
f54ebb5
chg: comment on SigSize check deletion according to changes in comet
marcello33 Sep 17, 2024
016da82
chg: restore sig check and bump comet
marcello33 Sep 18, 2024
d6897d2
chg: update VEHeight to 100 for testing
marcello33 Sep 20, 2024
f6cae67
add: new MsgUpdateParams / fix tests / bump heimdall
marcello33 Sep 26, 2024
8f50359
chg: pos-2695: replace stake module and skip some tests due to pos-2540
marcello33 Oct 2, 2024
590ce87
chg: fix simmetry in hex codec functions and add tests
marcello33 Oct 4, 2024
f4cdfd0
chg: additional checks on address hex codec
marcello33 Oct 7, 2024
0c645c8
chg: export RunTx
marcello33 Oct 7, 2024
e5ca416
POS-2622: chg: address consistency
marcello33 Oct 8, 2024
09e70f0
POS-2622: fix: function name
marcello33 Oct 8, 2024
08f48b4
POS-2700: fix: allow one msg per tx
marcello33 Oct 8, 2024
7b5b5c5
POS-2492: chg: pubKey checks / address utilities validations / enable…
marcello33 Oct 9, 2024
e5343e1
chg: solve several TODOs
marcello33 Oct 9, 2024
6cafe2a
chg: rename matic to pol
marcello33 Oct 10, 2024
ed6940b
import pos-2624 stake validator key as bytes
marcello33 Oct 10, 2024
c57d7e6
Revert "POS-2700: fix: allow one msg per tx"
marcello33 Oct 14, 2024
4fb1b9e
chg: make runTx private again
marcello33 Oct 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions testutil/sims/app_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ var DefaultConsensusParams = &cmtproto.ConsensusParams{
cmttypes.ABCIPubKeyTypeEd25519,
},
},
Abci: &cmtproto.ABCIParams{
marcello33 marked this conversation as resolved.
Show resolved Hide resolved
VoteExtensionsEnableHeight: 1,
},
}

// CreateRandomValidatorSet creates a validator set with one random validator
Expand Down
13 changes: 10 additions & 3 deletions types/module/module.go
Original file line number Diff line number Diff line change
Expand Up @@ -518,10 +518,17 @@ func (m *Manager) InitGenesis(ctx sdk.Context, cdc codec.JSONCodec, genesisData
}
}

// TODO HV2: This check is not present in v1.
// As staking is managed on L1,
// and our stake module's InitGenesis does not return []abci.ValidatorUpdate
// we should not need it. Is this assumption correct?

// a chain must initialize with a non-empty validator set
if len(validatorUpdates) == 0 {
return &abci.ResponseInitChain{}, fmt.Errorf("validator set is empty after InitGenesis, please ensure at least one validator is initialized with a delegation greater than or equal to the DefaultPowerReduction (%d)", sdk.DefaultPowerReduction)
}
/*
if len(validatorUpdates) == 0 {
return &abci.ResponseInitChain{}, fmt.Errorf("validator set is empty after InitGenesis, please ensure at least one validator is initialized with a delegation greater than or equal to the DefaultPowerReduction (%d)", sdk.DefaultPowerReduction)
}
*/
marcello33 marked this conversation as resolved.
Show resolved Hide resolved

return &abci.ResponseInitChain{
Validators: validatorUpdates,
Expand Down
Loading