forked from cosmos/cosmos-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for heimdall v2 init, new msg for updateParams #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@marcello33 your pull request is missing a changelog! |
sergio-mena
reviewed
Sep 5, 2024
sergio-mena
reviewed
Sep 6, 2024
sergio-mena
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marcello33
changed the title
[WIP] Fixes for heimdall v2 init
fixes for heimdall v2 init, new msg for updateParams
Sep 30, 2024
pratikspatil024
approved these changes
Oct 1, 2024
Raneet10
reviewed
Oct 3, 2024
Raneet10
approved these changes
Oct 3, 2024
… decorators / fix tests
This reverts commit 08f48b4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we slightly modify the code to be able to init a heimdall v2 application (used in v2 app tests).
For context, refer to this PR