Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: decouple CC parsing from creation #7288

Open
wants to merge 12 commits into
base: v14
Choose a base branch
from
Open

refactor: decouple CC parsing from creation #7288

wants to merge 12 commits into from
+11,865 −7,662

Conversation

AlCalzone
Copy link
Member

@AlCalzone AlCalzone commented Oct 18, 2024 •
edited
Loading

TODO:

  • Restore parsing behavior for "empty" CC implementations
  • Ensure that each CC implementation with a custom constructor also has a from() implementation
  • Ensure that node ID, encapsulation flags and endpoint index are passed through
  • Ensure that the message origin is passed through
  • get rid of sequenceNumber magic in Security S2

@AlCalzone AlCalzone marked this pull request as ready for review October 22, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AlCalzone