Zowe Suite v2.5.0-RC1

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,45 @@
+---
+name: Bug report
+about: Create a report to help us improve.
+title: ''
+labels: bug, new
+---
+
+<!-- Before opening a bug ticket, check if it can be solved by the website troubleshooting https://docs.zowe.org/stable/troubleshoot/troubleshooting or by using its search bar -->
+
+**Describe the bug**
+
+**Steps to Reproduce**
+
+1.
+2.
+
+**Expected behavior**
+
+**Screenshots (if needed)**
+
+**Logs**
+<!-- If applicable, add server logs collected at the time of your problem. -->
+<!-- Logs can contain some system information like hostnames, usernames, and IP/port info. -->
+<!-- Please sanitize your logs or reach out to the TSC or ZAC if you need to provide your logs with discretion -->
+<!-- Note you can increase log verbosity if desired. -->
+<!-- zwe command tracing: Use --trace on a zwe command -->
+<!-- zwe startup tracing: Set zowe.launchScript.logLevel to trace (https://github.com/zowe/zowe-install-packaging/blob/677a607686e6ee7ecb349dc5925a6f58dd9e61da/example-zowe.yaml#L356) -->
+<!-- app-server tracing: You can set any of the log levels here https://github.com/zowe/zlux-app-server/blob/d1b10b39bd0ba530784144430c33c19a5fb8f935/schemas/app-server-config.json#L378 using the guide here https://docs.zowe.org/stable/user-guide/mvd-configuration#logging-configuration -->
+<!-- zss tracing: Similar to app-server tracing, but with these loggers https://github.com/zowe/zss/blob/0bc9c812a5cd5a72768125d13826430e3a5bf1fb/schemas/zss-config.json#L216 -->
+
+
+**Describe your environment**
+<!-- Some items below may not apply to your use case, but answer as best as you can -->
+
+- Zowe version number (Check the Desktop login screen, or manifest.json in the Zowe install folder): 
+- Install method (pax, smpe, kubernetes, github clone):
+- Operating system (z/OS, kubernetes, etc) and OS version:
+- Node.js version number (Shown in logs, or via `node --version`):
+- Java version number (Shown in logs, or via `java -version`):
+- z/OSMF version:
+- What is the output of log message ZWES1014I:
+- Environment variables in use:
+
+
+**Additional context**

.github/ISSUE_TEMPLATE/bug_report_high.md

@@ -0,0 +1,45 @@
+---
+name: High-severity bug report
+about: Create a report on a high-severity bug. High severity is when there is an issue that has a major impact on usage of Zowe.
+title: ''
+labels: bug, new, severity-high
+---
+
+<!-- Before opening a bug ticket, check if it can be solved by the website troubleshooting https://docs.zowe.org/stable/troubleshoot/troubleshooting or by using its search bar -->
+
+**Describe the bug**
+
+**Steps to Reproduce**
+
+1.
+2.
+
+**Expected behavior**
+
+**Screenshots (if needed)**
+
+**Logs**
+<!-- If applicable, add server logs collected at the time of your problem. -->
+<!-- Logs can contain some system information like hostnames, usernames, and IP/port info. -->
+<!-- Please sanitize your logs or reach out to the TSC or ZAC if you need to provide your logs with discretion -->
+<!-- Note you can increase log verbosity if desired. -->
+<!-- zwe command tracing: Use --trace on a zwe command -->
+<!-- zwe startup tracing: Set zowe.launchScript.logLevel to trace (https://github.com/zowe/zowe-install-packaging/blob/677a607686e6ee7ecb349dc5925a6f58dd9e61da/example-zowe.yaml#L356) -->
+<!-- app-server tracing: You can set any of the log levels here https://github.com/zowe/zlux-app-server/blob/d1b10b39bd0ba530784144430c33c19a5fb8f935/schemas/app-server-config.json#L378 using the guide here https://docs.zowe.org/stable/user-guide/mvd-configuration#logging-configuration -->
+<!-- zss tracing: Similar to app-server tracing, but with these loggers https://github.com/zowe/zss/blob/0bc9c812a5cd5a72768125d13826430e3a5bf1fb/schemas/zss-config.json#L216 -->
+
+
+**Describe your environment**
+<!-- Some items below may not apply to your use case, but answer as best as you can -->
+
+- Zowe version number (Check the Desktop login screen, or manifest.json in the Zowe install folder): 
+- Install method (pax, smpe, kubernetes, github clone):
+- Operating system (z/OS, kubernetes, etc) and OS version:
+- Node.js version number (Shown in logs, or via `node --version`):
+- Java version number (Shown in logs, or via `java -version`):
+- z/OSMF version:
+- What is the output of log message ZWES1014I:
+- Environment variables in use:
+
+
+**Additional context**

.github/ISSUE_TEMPLATE/bug_report_low.md

@@ -0,0 +1,45 @@
+---
+name: Low-severity bug report
+about: Create a report on a low-severity bug. Low severity is when there is an issue that is inconvenient but doesn't impact key use cases.
+title: ''
+labels: bug, new, severity-low
+---
+
+<!-- Before opening a bug ticket, check if it can be solved by the website troubleshooting https://docs.zowe.org/stable/troubleshoot/troubleshooting or by using its search bar -->
+
+**Describe the bug**
+
+**Steps to Reproduce**
+
+1.
+2.
+
+**Expected behavior**
+
+**Screenshots (if needed)**
+
+**Logs**
+<!-- If applicable, add server logs collected at the time of your problem. -->
+<!-- Logs can contain some system information like hostnames, usernames, and IP/port info. -->
+<!-- Please sanitize your logs or reach out to the TSC or ZAC if you need to provide your logs with discretion -->
+<!-- Note you can increase log verbosity if desired. -->
+<!-- zwe command tracing: Use --trace on a zwe command -->
+<!-- zwe startup tracing: Set zowe.launchScript.logLevel to trace (https://github.com/zowe/zowe-install-packaging/blob/677a607686e6ee7ecb349dc5925a6f58dd9e61da/example-zowe.yaml#L356) -->
+<!-- app-server tracing: You can set any of the log levels here https://github.com/zowe/zlux-app-server/blob/d1b10b39bd0ba530784144430c33c19a5fb8f935/schemas/app-server-config.json#L378 using the guide here https://docs.zowe.org/stable/user-guide/mvd-configuration#logging-configuration -->
+<!-- zss tracing: Similar to app-server tracing, but with these loggers https://github.com/zowe/zss/blob/0bc9c812a5cd5a72768125d13826430e3a5bf1fb/schemas/zss-config.json#L216 -->
+
+
+**Describe your environment**
+<!-- Some items below may not apply to your use case, but answer as best as you can -->
+
+- Zowe version number (Check the Desktop login screen, or manifest.json in the Zowe install folder): 
+- Install method (pax, smpe, kubernetes, github clone):
+- Operating system (z/OS, kubernetes, etc) and OS version:
+- Node.js version number (Shown in logs, or via `node --version`):
+- Java version number (Shown in logs, or via `java -version`):
+- z/OSMF version:
+- What is the output of log message ZWES1014I:
+- Environment variables in use:
+
+
+**Additional context**

.github/ISSUE_TEMPLATE/bug_report_medium.md

@@ -0,0 +1,45 @@
+---
+name: Medium-severity bug report
+about: Create a report on a medium-severity bug. Medium severity is when there is an issue that makes the use of Zowe difficult, but has a workaround or doesn't prevent the use of Zowe.
+title: ''
+labels: bug, new, severity-medium
+---
+
+<!-- Before opening a bug ticket, check if it can be solved by the website troubleshooting https://docs.zowe.org/stable/troubleshoot/troubleshooting or by using its search bar -->
+
+**Describe the bug**
+
+**Steps to Reproduce**
+
+1.
+2.
+
+**Expected behavior**
+
+**Screenshots (if needed)**
+
+**Logs**
+<!-- If applicable, add server logs collected at the time of your problem. -->
+<!-- Logs can contain some system information like hostnames, usernames, and IP/port info. -->
+<!-- Please sanitize your logs or reach out to the TSC or ZAC if you need to provide your logs with discretion -->
+<!-- Note you can increase log verbosity if desired. -->
+<!-- zwe command tracing: Use --trace on a zwe command -->
+<!-- zwe startup tracing: Set zowe.launchScript.logLevel to trace (https://github.com/zowe/zowe-install-packaging/blob/677a607686e6ee7ecb349dc5925a6f58dd9e61da/example-zowe.yaml#L356) -->
+<!-- app-server tracing: You can set any of the log levels here https://github.com/zowe/zlux-app-server/blob/d1b10b39bd0ba530784144430c33c19a5fb8f935/schemas/app-server-config.json#L378 using the guide here https://docs.zowe.org/stable/user-guide/mvd-configuration#logging-configuration -->
+<!-- zss tracing: Similar to app-server tracing, but with these loggers https://github.com/zowe/zss/blob/0bc9c812a5cd5a72768125d13826430e3a5bf1fb/schemas/zss-config.json#L216 -->
+
+
+**Describe your environment**
+<!-- Some items below may not apply to your use case, but answer as best as you can -->
+
+- Zowe version number (Check the Desktop login screen, or manifest.json in the Zowe install folder): 
+- Install method (pax, smpe, kubernetes, github clone):
+- Operating system (z/OS, kubernetes, etc) and OS version:
+- Node.js version number (Shown in logs, or via `node --version`):
+- Java version number (Shown in logs, or via `java -version`):
+- z/OSMF version:
+- What is the output of log message ZWES1014I:
+- Environment variables in use:
+
+
+**Additional context**

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,25 @@
+---
+name: Feature request
+about: Suggest an idea for ZSS
+labels: enhancement, new
+---
+
+<!-- Thanks for deciding to open an issue. Before submitting, please complete the following information. -->
+
+**Is your feature or enhancement request related to a problem or limitation? Please describe**
+
+<!-- A clear and concise description of the problem or limitation. Example: I'm frustrated when [...] happens, or I wish I was able to [...] with Zowe -->
+
+**Describe your enhancement idea**
+
+<!-- A clear and concise description of what you want to happen, such as the task you are trying to complete. -->
+<!-- Please attach images or references if it helps you describe what you'd like -->
+
+**Describe alternatives you've considered**
+
+<!-- A clear and concise description of any alternative solutions or workarounds you've used to overcome the problem or limitation. -->
+
+**Provide any additional context**
+
+<!-- Add any other context (code snippets, error messages, sample outputs, screenshots) about the request here. -->
+

.github/pull_request_template.md

@@ -3,7 +3,7 @@
 ## Proposed changes
 <!-- Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. -->
 
-This PR addresses Issue: [*Link to Github issue within https://github.com/zowe/zlux/issues* if any]
+This PR addresses Issue: [*Link to Github issue within https://github.com/zowe/zss/issues* if any]
 
 This PR depends upon the following PRs:
 
@@ -19,7 +19,7 @@ Please delete options that are not relevant.
 ## PR Checklist
 Please delete options that are not relevant.
 - [ ] If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
-- [ ] My code follows the style guidelines of this project (see: [Contributing guideline](https://github.com/zowe/zlux/blob/master/CONTRIBUTING.md))
+- [ ] My code follows the style guidelines of this project (see: [Contributing guideline](https://github.com/zowe/zss/blob/v2.x/master/CONTRIBUTING.md))
 - [ ] I have commented my code, particularly in hard-to-understand areas
 - [ ] I have made corresponding changes to the documentation
 - [ ] New and existing unit tests pass locally with my changes

.github/workflows/stale.yml

@@ -0,0 +1,30 @@
+name: 'Close stale issues and PRs'
+on:
+  schedule:
+    - cron: '0 */6 * * *'
+
+permissions:
+  issues: write
+  pull-requests: write
+
+jobs:
+  stale:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/stale@v5
+        with:
+          close-issue-message: >
+            This issue has been automatically closed due to lack of activity.
+            If this issue is still valid and important to you, it can be reopened.
+          days-before-close: 90
+          days-before-stale: 180
+          exempt-all-assignees: true
+          exempt-all-milestones: true
+          exempt-issue-labels: "community-upvoted, dependency, for-review, keep, security, high-severity, critical-severity, help-wanted, good-first-issue"
+          stale-issue-label: "stale-reopen-if-needed"
+          stale-issue-message: >
+            This issue has been automatically marked as stale because it has not had
+            recent activity. It will be closed if no further activity occurs,
+            but can be reopened if needed. Thank you for your contributions.
+          stale-pr-label: "stale-reopen-if-needed"
+          start-date: "2022-05-30T00:00:00Z"

CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to the ZSS package will be documented in this file.
 
 ## Recent Changes
 
+## `2.5.0`
+
+- Bugfix: In 2.3 and 2.4, 'safkeyring://' syntax stopped working, only allowing 'safkeyring:////'. Now, support for both is restored.
+- Support ZIS runtime version check 
+- Update the dynamic linkage stub vector to include new functions
+- Add ZIS plugin development documentation and samples
+
 ## `2.4.0`
 
 - Enhancement: ZSS /datasetContents now has a PUT API for creating datasets.

c/zis/server-api.c

@@ -32,9 +32,34 @@ _Bool zisIsLPADevModeOn(const ZISContext *context) {
 }
 
 void zisGetServerVersion(int *major, int *minor, int *revision) {
-  *major = ZIS_MAJOR_VERSION;
-  *minor = ZIS_MINOR_VERSION;
-  *revision = ZIS_REVISION;
+  *major = -1;
+  *minor = -1;
+  *revision = -1;
+  CAA *caa = (CAA *)getCAA();
+  if (caa == NULL) {
+    return;
+  }
+  RLETask *task = caa->rleTask;
+  if (task == NULL) {
+    return;
+  }
+  RLEAnchor *rleAnchor = task->anchor;
+  if (rleAnchor == NULL) {
+    return;
+  }
+  ZISContext *context = NULL;
+  if (getRLEApplicationAnchor(rleAnchor, (void **)&context)) {
+    return;
+  }
+  if (!(context->zisAnchor->flags & ZIS_SERVER_ANCHOR_VERSIONED_CONTEXT)) {
+    return;
+  }
+  if (context->version < ZIS_CONTEXT_VERSION_ZIS_VERSION_SUPPORT) {
+    return;
+  }
+  *major = context->zisVersion.major;
+  *minor = context->zisVersion.minor;
+  *revision = context->zisVersion.revision;
 }
 
 /*

c/zis/server.c

@@ -1109,6 +1109,7 @@ ZISServerAnchor *createZISServerAnchor() {
 
   /* new feature bit for dynamic linking - Fall 2021 */
   anchor->flags |= ZIS_SERVER_ANCHOR_FLAG_DYNLINK;
+  anchor->flags |= ZIS_SERVER_ANCHOR_VERSIONED_CONTEXT;
 
   return anchor;
 }
@@ -1118,6 +1119,10 @@ static void enableDynLink(ZISServerAnchor *anchor) {
   anchor->flags |= ZIS_SERVER_ANCHOR_FLAG_DYNLINK;
 }
 
+static void enableVersionedContext(ZISServerAnchor *anchor) {
+  anchor->flags |= ZIS_SERVER_ANCHOR_VERSIONED_CONTEXT;
+}
+
 static void removeZISServerAnchor(ZISServerAnchor **anchor) {
 
   unsigned int size = sizeof(ZISServerAnchor);
@@ -1143,6 +1148,8 @@ static int initGlobalResources(ZISContext *context) {
   } else {
     // make sure any existing anchors supports dynamic linkage now
     enableDynLink(anchor);
+    // make sure it also supports a versioned ZIS context
+    enableVersionedContext(anchor);
   }
   context->zisAnchor = anchor;
 
@@ -1158,6 +1165,11 @@ static ZISContext makeContext(STCBase *base) {
 
   ZISContext cntx = {
       .eyecatcher = ZIS_CONTEXT_EYECATCHER,
+      .version = ZIS_CONTEXT_VERSION,
+      .size = sizeof(ZISContext),
+      .zisVersion.major = ZIS_MAJOR_VERSION,
+      .zisVersion.minor = ZIS_MINOR_VERSION,
+      .zisVersion.revision = ZIS_REVISION,
       .stcBase = base,
       .parms = NULL,
       .cmServer = NULL,
@@ -1370,6 +1382,8 @@ static int initContext(ZISContext *context) {
   memcpy(context->dynlinkModuleNameNullTerm, context->zisModuleName.text, 4);
   strcat(context->dynlinkModuleNameNullTerm, ZIS_DYN_LINKAGE_PLUGIN_MOD_SUFFIX);
 
+  setRLEApplicationAnchor(context->stcBase->rleAnchor, context);
+
   return RC_ZIS_OK;
 }
 

c/zis/stubinit.c

@@ -273,6 +273,8 @@
     stubVector[ZIS_STUB_LETMRLEE] = (void*)termRLEEnvironment;
     stubVector[ZIS_STUB_LEMKFCAA] = (void*)makeFakeCAA;
     stubVector[ZIS_STUB_LEARTCAA] = (void*)abortIfUnsupportedCAA;
+    stubVector[ZIS_STUB_LESETANC] = (void*)setRLEApplicationAnchor;
+    stubVector[ZIS_STUB_LEGETANC] = (void*)getRLEApplicationAnchor;
     stubVector[ZIS_STUB_MKLOGCTX] = (void*)makeLoggingContext;
     stubVector[ZIS_STUB_MKLLGCTX] = (void*)makeLocalLoggingContext;
     stubVector[ZIS_STUB_RMLOGCTX] = (void*)removeLoggingContext;