Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate VSAM storage option in v3 #3969

Merged
merged 12 commits into from
Sep 5, 2024
11 changes: 4 additions & 7 deletions example-zowe.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -565,17 +565,14 @@ components:

storage:
evictionStrategy: reject
# can be inMemory, VSAM, redis or infinispan
mode: VSAM
size: 10000
vsam:
# your VSAM data set created by "zwe init vsam" command or ZWECSVSM JCL
# this is required if storage mode is VSAM
name: ""
# can be infinispan, inMemory, redis or VSAM(deprecated)
mode: infinispan
infinispan:
# this is required if storage mode is infinispan
jgroups:
port: 7600
keyExchange:
port: 7601

# >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
app-server:
Expand Down
2 changes: 1 addition & 1 deletion playbooks/all_host_vars_list.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ zowe_apiml_security_zosmf_applid: IZUDFLT
zowe_apiml_security_zosmf_jwt_autoconfiguration_mode: AUTO
zowe_apiml_verify_certficates_of_services: true
zowe_auto_create_user_group: false
zowe_caching_service_persistent: VSAM
zowe_caching_service_persistent: infinispan
zowe_caching_service_port: 7555
zowe_caching_service_vsam_dsprefix: CACHE
zowe_caching_vsam_storage_class:
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/configure/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ zowe_mvs_explorer_port: 7561
zowe_uss_explorer_port: 7562
# caching service
zowe_caching_service_port: 7555
zowe_caching_service_persistent: VSAM
zowe_caching_service_persistent: infinispan
# the final data set name will be: {zowe_dataset_prefix}.{zowe_caching_service_vsam_dsprefix}{zowe_instance_id}
# for example: IBMUSER.ZWE.CACHE1
zowe_caching_service_vsam_dsprefix: CACHE
Expand Down
3 changes: 0 additions & 3 deletions playbooks/roles/configure/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,7 @@
tasks_from: update_zowe_yaml
vars:
configs:
"zowe.setup.vsam.volume": "{{ zowe_caching_vsam_volume }}"
"zowe.setup.vsam.storageClass": "{{ zowe_caching_vsam_storage_class }}"
"components.caching-service.storage.mode": "{{ zowe_caching_service_persistent }}"
"components.caching-service.storage.vsam.name": "{{ zowe_dataset_prefix }}.{{ zowe_caching_service_vsam_dsprefix }}{{ zowe_instance_id }}"

- name: Update zowe.yaml zowe.setup.vsam.mode to NONRLS
import_role:
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/custom_for_test/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ zowe_mvs_explorer_port: 7561
zowe_uss_explorer_port: 7562
# caching service
zowe_caching_service_port: 7555
zowe_caching_service_persistent: VSAM
zowe_caching_service_persistent: infinispan
# the final data set name will be: {zowe_dataset_prefix}.{zowe_caching_service_vsam_dsprefix}{zowe_instance_id}
# for example: IBMUSER.ZWE.CACHE1
zowe_caching_service_vsam_dsprefix: CACHE
Expand Down
2 changes: 1 addition & 1 deletion playbooks/roles/custom_for_test/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@

# ============================================================================
# Enable disabled services
- name: Update zowe.yaml zowe.setup.vsam
- name: Update zowe.yaml
import_role:
name: zos
tasks_from: update_zowe_yaml
Expand Down
16 changes: 16 additions & 0 deletions workflows/files/ZWECONF.properties
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,22 @@ components_caching_service_storage_vsam_name=
# Port for jgroups. This is required if storage mode is infinispan.
components_caching_service_storage_infinispan_jgroups_port=7600

# components_caching_service_storage_infinispan_jgroups_host
# Label: Caching service storage jgroups host
# Abstract: Host for jgroups
# Category: components
# Description:
# Host for jgroups
components_caching_service_storage_infinispan_jgroups_host=
muzikovam marked this conversation as resolved.
Show resolved Hide resolved

# components_caching_service_storage_infinispan_jgroups_keyExchange_port
# Label: Caching service storage jgroups key exchange port
# Abstract: Port for jgroups key exchang
# Category: components
# Description:
# Port for jgroups key exchange. This is required if storage mode is infinispan.
components_caching_service_storage_infinispan_jgroups_keyExchange_port=7601

# components_app_server_enabled
# Label: Enable app server
# Abstract: Check this option to enable the app server
Expand Down
43 changes: 36 additions & 7 deletions workflows/files/ZWECONF.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
<autoTakeOwnership>true</autoTakeOwnership>
<!-- instance prefix settings -->
<workflowInfo>
<workflowID scope="none">config_zowe_20</workflowID>
<workflowDefaultName>Configuration of Zowe 2.0</workflowDefaultName>
<workflowDescription>Use this workflow to configure the Zowe 2.0</workflowDescription>
<workflowID scope="none">config_zowe_30</workflowID>
<workflowDefaultName>Configuration of Zowe 3.0</workflowDefaultName>
<workflowDescription>Use this workflow to configure the Zowe 3.0</workflowDescription>
<workflowVersion>###ZOWE_VERSION###</workflowVersion>
<vendor>Zowe</vendor>
<General/>
Expand Down Expand Up @@ -702,7 +702,7 @@ How we want to verify SSL certificates of services. Valid values are:
<choice>redis</choice>
<choice>infinispan</choice>
<choice>VSAM</choice>
<default>VSAM</default>
<default>infinispan</default>
</string>
</variable>
<variable name="components_caching_service_storage_size" scope="instance" visibility="public">
Expand Down Expand Up @@ -737,6 +737,28 @@ How we want to verify SSL certificates of services. Valid values are:
<default>7600</default>
</string>
</variable>
<variable name="components_caching_service_storage_infinispan_jgroups_host" scope="instance" visibility="public">
<label>Caching service storage jgroups host</label>
<abstract>Host for jgroups</abstract>
<description>Host for jgroups. Default value is the same as Zowe host and it is used if storage mode is infinispan.</description>
<category>components</category>
<string valueMustBeChoice="false" multiLine="false">
<!-- Put validation here -->
<!-- Specify choices here -->
<default>dvipa.my-company.com</default>
</string>
</variable>
<variable name="components_caching_service_storage_infinispan_jgroups_keyExchange_port" scope="instance" visibility="public">
<label>Caching service storage jgroups keyExchange port</label>
<abstract>Port for jgroups key exchange</abstract>
<description>Port for jgroups key exchange. This is required if storage mode is infinispan.</description>
<category>components</category>
<string valueMustBeChoice="false" multiLine="false">
<!-- Put validation here -->
<!-- Specify choices here -->
<default>7601</default>
</string>
</variable>
<variable name="components_app_server_enabled" scope="instance" visibility="public">
<label>Enable the app server</label>
<abstract>Check this option to enable the app server</abstract>
Expand Down Expand Up @@ -1303,7 +1325,7 @@ How we want to verify SSL certificates of services. Valid values are:
<canMarkAsFailed>false</canMarkAsFailed>
<!--template-->
</step>
<step name="caching_service_vsam_variables" optional="false">
<step name="caching_service_vsam_variables" optional="true">
<title>Variables for Caching Service - VSAM mode</title>
<description>Specify the variables for the VSAM mode of Caching Service</description>
<prereqStep name="caching_service_variables"/>
Expand All @@ -1323,10 +1345,10 @@ How we want to verify SSL certificates of services. Valid values are:
</extendStateExpression>
</targetStateSet>
</condition>
<variableValue name="zowe_setup_vsam_mode" scope="instance" noPromptIfSet="false" required="true"/>
<variableValue name="zowe_setup_vsam_mode" scope="instance" noPromptIfSet="false" required="false"/>
<variableValue name="zowe_setup_vsam_volume" scope="instance" noPromptIfSet="false" required="false"/>
<variableValue name="zowe_setup_vsam_storageClass" scope="instance" noPromptIfSet="false" required="false"/>
<variableValue name="components_caching_service_storage_vsam_name" scope="instance" noPromptIfSet="false" required="true"/>
<variableValue name="components_caching_service_storage_vsam_name" scope="instance" noPromptIfSet="false" required="false"/>
<instructions substitution="false">Run this step to specify the variables for the Caching Service</instructions>
<weight>1</weight>
<skills>z/OS System Programmer</skills>
Expand Down Expand Up @@ -1356,6 +1378,8 @@ How we want to verify SSL certificates of services. Valid values are:
</targetStateSet>
</condition>
<variableValue name="components_caching_service_storage_infinispan_jgroups_port" scope="instance" noPromptIfSet="false" required="false"/>
<variableValue name="components_caching_service_storage_infinispan_jgroups_host" scope="instance" noPromptIfSet="false" required="false"/>
<variableValue name="components_caching_service_storage_infinispan_jgroups_keyExchange_port" scope="instance" noPromptIfSet="false" required="false"/>
<instructions substitution="false">Run this step to specify the variables for the Caching Service</instructions>
<weight>1</weight>
<skills>z/OS System Programmer</skills>
Expand Down Expand Up @@ -2104,8 +2128,13 @@ echo ' # this is required if storage mode is infinispan' >> "${instance-z
echo ' jgroups:' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
#if (${instance-components_caching_service_storage_mode} == "infinispan" )
echo ' port: ${instance-components_caching_service_storage_infinispan_jgroups_port}' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' host: ${instance-components_caching_service_storage_infinispan_jgroups_host}' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' keyExchange: ' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' port: ${instance-components_caching_service_storage_infinispan_jgroups_keyExchange_port}' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
#else
echo ' port: 7600' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
echo ' keyExchange: ' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
muzikovam marked this conversation as resolved.
Show resolved Hide resolved
echo ' port: 7601' >> "${instance-zowe_runtimeDirectory}/zowe.yaml"
#end
#end
#if (${instance-components_caching_service_enabled} == "false" )
Expand Down
Loading