Close unused pipes (#3590)

Signed-off-by: Martin Zeithaml <[email protected]>
zowe · Oct 11, 2023 · 8f981ac · 8f981ac
1 parent 4c8809b
commit 8f981ac
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/bin/libs/shell.ts b/bin/libs/shell.ts
@@ -73,10 +73,10 @@ export function execOutSync(command: string, ...args: string[]): ExecReturn {
     return { rc: -1 };
   }
   const rc = os.exec([command, ...args], { block: true, usePath: true, stdout: pipeArray[1]});
+  os.close(pipeArray[1]);
 
   let out = readStreamFully(pipeArray[0]);
   os.close(pipeArray[0]);
-  os.close(pipeArray[1]);
 
   return {
     rc, out
@@ -94,11 +94,11 @@ export function execErrSync(command: string, ...args: string[]): ExecReturn {
   if (!pipeArray){
     return { rc: -1 };
   }
-  const rc = os.exec([command, ...args], { block: true, usePath: true, stderr: pipeArray[1]});
-
+  const rc = os.exec([command, ...args], { block: true, usePath: true, stderr: pipeArray[1]}); 
+  os.close(pipeArray[1]);  
+
   let err = readStreamFully(pipeArray[0]);
   os.close(pipeArray[0]);
-  os.close(pipeArray[1]);
 
   return {
     rc, err
@@ -117,16 +117,17 @@ export function execOutErrSync(command: string, ...args: string[]): ExecReturn {
     return { rc: -1 };
   }
   const rc = os.exec([command, ...args], { block: true, usePath: true, stdout: pipeArray[1], stderr: errArray[1]});
+  os.close(pipeArray[1]);
+  os.close(errArray[1]);
 
   let out = readStreamFully(pipeArray[0]);
   os.close(pipeArray[0]);
-  os.close(pipeArray[1]);
-
+
   let err = readStreamFully(errArray[0]);
   os.close(errArray[0]);
-  os.close(errArray[1]);
+
   return {
-    rc, err
+    rc, out, err 
   };
 }