Feature copy datasets

.eslintrc.yaml

@@ -12,6 +12,8 @@ rules:
   "@typescript-eslint/no-var-requires": warn
   no-unused-expressions: off
   "@typescript-eslint/no-unused-expressions": warn
+  no-unused-vars: off
+  "@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }]
   curly: warn
   max-len:
     - warn
@@ -37,3 +39,7 @@ rules:
       filePathPattern: ".*\\.unit\\.test\\..*"
 parserOptions:
   sourceType: module
+overrides:
+  - files: "**/__tests__/**"
+    rules:
+      no-magic-numbers: off

.github/workflows/theia-zowe-explorer-ci.yml

@@ -75,7 +75,7 @@ jobs:
       - run: yarn workspace vscode-extension-for-zowe test:theia
 
       - name: Upload test results
-        if: success() || failure()      
+        if: success() || failure()
         uses: actions/upload-artifact@v2
         with:
           name: theia-zowe-explorer-results

packages/zowe-explorer-api/CHANGELOG.md

@@ -6,6 +6,8 @@ All notable changes to the "zowe-explorer-api" extension will be documented in t
 
 ### New features and enhancements
 
+- Added copy datasets APIs. [#1550] (https://github.com/zowe/vscode-extension-for-zowe/issues/1550)
+
 ### Bug fixes
 
 ## `2.6.0`

packages/zowe-explorer-api/src/profiles/ZoweExplorerApi.ts

@@ -331,6 +331,17 @@ export namespace ZoweExplorerApi {
          * @returns {Promise<zowe.IZosFilesResponse>}
          */
         dataSetsMatchingPattern?(filter: string[], options?: zowe.IDsmListOptions): Promise<zowe.IZosFilesResponse>;
+
+        /**
+         * Copies a dataSet.
+         *
+         * @param {string} fromDataSetName
+         * @param {string} toDataSetName
+         * @param {string?} enq possible values : {SHR, SHRW, EXCLU}
+         * @param {boolean?} replace
+         * @returns {Promise<zowe.IZosFilesResponse>}
+         */
+        copyDataSet?(fromDataSetName: string, toDataSetName: string, enq?: string, replace?: boolean): Promise<zowe.IZosFilesResponse>;
     }
 
     /**

packages/zowe-explorer-api/src/profiles/ZoweExplorerZosmfApi.ts

@@ -248,6 +248,9 @@ export class ZosmfMvsApi extends ZosmfApiCommon implements ZoweExplorerApi.IMvs
     public dataSetsMatchingPattern(filter: string[], options?: zowe.IDsmListOptions): Promise<zowe.IZosFilesResponse> {
         return zowe.List.dataSetsMatchingPattern(this.getSession(), filter, options);
     }
+    public copyDataSet(fromDataSetName: string, toDataSetName: string, enq?: string, replace?: boolean): Promise<zowe.IZosFilesResponse> {
+        return zowe.Copy.dataSet(this.getSession(), { dsn: toDataSetName }, { "from-dataset": { dsn: fromDataSetName }, enq, replace });
+    }
 }
 
 /**

packages/zowe-explorer-ftp-extension/CHANGELOG.md

@@ -4,6 +4,8 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen
 
 ### New features and enhancements
 
+- Updated UI/UX method calls to use standalone `Gui` module for better usability and maintainability . [#1967](https://github.com/zowe/vscode-extension-for-zowe/issues/1967)
+
 ### Bug fixes
 
 ## `2.6.0`

packages/zowe-explorer-ftp-extension/__mocks__/vscode.ts

@@ -18,18 +18,15 @@ export namespace window {
      * @param items A set of items that will be rendered as actions in the message.
      * @return A thenable that resolves to the selected item or `undefined` when being dismissed.
      */
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    export function showInformationMessage(message: string, ...items: string[]): undefined {
+    export function showInformationMessage(_message: string, ..._items: string[]): undefined {
         return undefined;
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    export function showErrorMessage(message: string, ...items: string[]): undefined {
+    export function showErrorMessage(_message: string, ..._items: string[]): undefined {
         return undefined;
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    export function setStatusBarMessage(message: string, ...items: string[]): undefined {
+    export function setStatusBarMessage(_message: string, ..._items: string[]): undefined {
         return undefined;
     }
 

packages/zowe-explorer-ftp-extension/__tests__/__unit__/Mvs/ZoweExplorerFtpMvsApi.unit.test.ts

@@ -209,6 +209,16 @@ describe("FtpMvsApi", () => {
         expect(MvsApi.releaseConnection).toBeCalled();
     });
 
+    it("should give error copy datasets.", async () => {
+        try {
+            await MvsApi.copyDataSet(null, null);
+        } catch (error) {
+            // do nth
+        }
+        const copySpy = jest.spyOn(Gui, "errorMessage");
+        expect(copySpy).toHaveBeenCalled();
+    });
+
     it("should throw an error when hMigrateDataSet is called", async () => {
         jest.spyOn(Gui, "errorMessage").mockImplementation();
         await expect(MvsApi.hMigrateDataSet("test")).rejects.toThrowError();

packages/zowe-explorer-ftp-extension/src/ZoweExplorerAbstractFtpApi.ts

@@ -82,8 +82,7 @@ export abstract class AbstractFtpApi implements ZoweExplorerApi.ICommon {
         }
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    public logout(session): Promise<void> {
+    public logout(_session): Promise<void> {
         const ftpsession = sessionMap.get(this.profile);
         if (ftpsession !== undefined) {
             ftpsession.releaseConnections();

packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpJesApi.ts

@@ -95,7 +95,7 @@ export class FtpJesApi extends AbstractFtpApi implements ZoweExplorerApi.IJes {
             connection = await this.ftpClient(this.checkedProfile());
             if (connection) {
                 const response: IJobStatus = await JobUtils.findJobByID(connection, jobid);
-                const files: any = response.spoolFiles;
+                const files = response.spoolFiles;
                 if (files) {
                     // eslint-disable-next-line @typescript-eslint/no-unsafe-return,@typescript-eslint/no-unsafe-call
                     return files.map((file: ISpoolFile) => {
@@ -109,7 +109,7 @@ export class FtpJesApi extends AbstractFtpApi implements ZoweExplorerApi.IJes {
                             procstep: (file as ISpoolFileRefactor).procStep || file.procstep,
                             class: file.class,
                             ddname: (file as ISpoolFileRefactor).ddName || file.ddname,
-                        };
+                        } as unknown as zowe.IJobFile;
                     });
                 }
             }
@@ -184,14 +184,12 @@ export class FtpJesApi extends AbstractFtpApi implements ZoweExplorerApi.IJes {
         }
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    public async getJclForJob(job: zowe.IJob): Promise<string> {
+    public async getJclForJob(_job: zowe.IJob): Promise<string> {
         await Gui.errorMessage("Get jcl is not supported in the FTP extension.", { logger: ZoweLogger });
         throw new Error();
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    public async submitJcl(jcl: string, internalReaderRecfm?: string, internalReaderLrecl?: string): Promise<zowe.IJob> {
+    public async submitJcl(_jcl: string, _internalReaderRecfm?: string, _internalReaderLrecl?: string): Promise<zowe.IJob> {
         await Gui.errorMessage("Submit jcl is not supported in the FTP extension.", { logger: ZoweLogger });
         throw new Error();
     }

packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpMvsApi.ts

@@ -28,8 +28,7 @@ import { ZoweLogger } from "./extension";
 const MAX_MEMBER_NAME_LEN = 8;
 
 export class FtpMvsApi extends AbstractFtpApi implements ZoweExplorerApi.IMvs {
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    public async dataSet(filter: string, options?: zowe.IListOptions): Promise<zowe.IZosFilesResponse> {
+    public async dataSet(filter: string, _options?: zowe.IListOptions): Promise<zowe.IZosFilesResponse> {
         const result = this.getDefaultResponse();
         const session = this.getSession(this.profile);
         if (session.mvsListConnection === undefined || session.mvsListConnection.connected === false) {
@@ -54,8 +53,7 @@ export class FtpMvsApi extends AbstractFtpApi implements ZoweExplorerApi.IMvs {
         return result;
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    public async allMembers(dataSetName: string, options?: zowe.IListOptions): Promise<zowe.IZosFilesResponse> {
+    public async allMembers(dataSetName: string, _options?: zowe.IListOptions): Promise<zowe.IZosFilesResponse> {
         const result = this.getDefaultResponse();
         let connection;
         try {
@@ -264,24 +262,25 @@ export class FtpMvsApi extends AbstractFtpApi implements ZoweExplorerApi.IMvs {
         }
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    public async allocateLikeDataSet(dataSetName: string, likeDataSetName: string): Promise<zowe.IZosFilesResponse> {
+    public async allocateLikeDataSet(_dataSetName: string, _likeDataSetName: string): Promise<zowe.IZosFilesResponse> {
         await Gui.errorMessage("Allocate like dataset is not supported in ftp extension.", { logger: ZoweLogger });
         throw new Error();
     }
 
     public async copyDataSetMember(
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        { dsn: fromDataSetName, member: fromMemberName }: zowe.IDataSet,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        { dsn: toDataSetName, member: toMemberName }: zowe.IDataSet,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        options?: { replace?: boolean }
+        { dsn: _fromDataSetName, member: _fromMemberName }: zowe.IDataSet,
+        { dsn: _toDataSetName, member: _toMemberName }: zowe.IDataSet,
+        _options?: { replace?: boolean }
     ): Promise<zowe.IZosFilesResponse> {
         await Gui.errorMessage("Copy dataset is not supported in ftp extension.", { logger: ZoweLogger });
         throw new Error();
     }
 
+    public async copyDataSet(_fromDataSetName: string, _toDataSetName: string, _enq?: string, _replace?: boolean): Promise<zowe.IZosFilesResponse> {
+        await Gui.errorMessage("Copy dataset is not supported in ftp extension.", { logger: ZoweLogger });
+        throw new Error();
+    }
+
     public async renameDataSet(currentDataSetName: string, newDataSetName: string): Promise<zowe.IZosFilesResponse> {
         const result = this.getDefaultResponse();
         let connection;
@@ -322,22 +321,16 @@ export class FtpMvsApi extends AbstractFtpApi implements ZoweExplorerApi.IMvs {
         }
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    public async hMigrateDataSet(dataSetName: string): Promise<zowe.IZosFilesResponse> {
+    public async hMigrateDataSet(_dataSetName: string): Promise<zowe.IZosFilesResponse> {
         await Gui.errorMessage("Migrate dataset is not supported in ftp extension.", { logger: ZoweLogger });
         throw new Error();
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    public async hRecallDataSet(dataSetName: string): Promise<zowe.IZosFilesResponse> {
+    public async hRecallDataSet(_dataSetName: string): Promise<zowe.IZosFilesResponse> {
         await Gui.errorMessage("Recall dataset is not supported in ftp extension.", { logger: ZoweLogger });
         throw new Error();
     }
-    public async deleteDataSet(
-        dataSetName: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        options?: zowe.IDeleteDatasetOptions
-    ): Promise<zowe.IZosFilesResponse> {
+    public async deleteDataSet(dataSetName: string, _options?: zowe.IDeleteDatasetOptions): Promise<zowe.IZosFilesResponse> {
         const result = this.getDefaultResponse();
         let connection;
         try {
@@ -381,7 +374,7 @@ export class FtpMvsApi extends AbstractFtpApi implements ZoweExplorerApi.IMvs {
             input.on("readable", () => {
                 const data = input.read();
                 if (data) {
-                    hash.update(data);
+                    hash.update(data as unknown as crypto.BinaryLike);
                 } else {
                     resolve(`${hash.digest("hex")}`);
                 }

packages/zowe-explorer-ftp-extension/src/ZoweExplorerFtpUssApi.ts

@@ -49,8 +49,8 @@ export class FtpUssApi extends AbstractFtpApi implements ZoweExplorerApi.IUss {
         return result;
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars, @typescript-eslint/require-await, require-await
-    public async isFileTagBinOrAscii(ussFilePath: string): Promise<boolean> {
+    // eslint-disable-next-line @typescript-eslint/require-await, require-await
+    public async isFileTagBinOrAscii(_ussFilePath: string): Promise<boolean> {
         return false; // TODO: needs to be implemented checking file type
     }
 
@@ -125,12 +125,7 @@ export class FtpUssApi extends AbstractFtpApi implements ZoweExplorerApi.IUss {
         }
     }
 
-    public async uploadDirectory(
-        inputDirectoryPath: string,
-        ussDirectoryPath: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        options: IUploadOptions
-    ): Promise<zowe.IZosFilesResponse> {
+    public async uploadDirectory(inputDirectoryPath: string, ussDirectoryPath: string, _options: IUploadOptions): Promise<zowe.IZosFilesResponse> {
         let result = this.getDefaultResponse();
 
         // Check if inputDirectory is directory
@@ -149,12 +144,7 @@ export class FtpUssApi extends AbstractFtpApi implements ZoweExplorerApi.IUss {
         return result;
     }
 
-    public async create(
-        ussPath: string,
-        type: string,
-        // eslint-disable-next-line @typescript-eslint/no-unused-vars
-        mode?: string
-    ): Promise<zowe.IZosFilesResponse> {
+    public async create(ussPath: string, type: string, _mode?: string): Promise<zowe.IZosFilesResponse> {
         const result = this.getDefaultResponse();
         let connection;
         try {
@@ -262,7 +252,7 @@ export class FtpUssApi extends AbstractFtpApi implements ZoweExplorerApi.IUss {
             input.on("readable", () => {
                 const data = input.read();
                 if (data) {
-                    hash.update(data);
+                    hash.update(data as unknown as crypto.BinaryLike);
                 } else {
                     resolve(`${hash.digest("hex")}`);
                 }

packages/zowe-explorer-ftp-extension/src/extension.ts

@@ -21,13 +21,11 @@ import { FtpSession } from "./ftpSession";
 
 export const ZoweLogger = new IZoweLogger("Zowe Explorer FTP Extension", path.join(__dirname, "..", ".."));
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-export function activate(context: vscode.ExtensionContext): void {
+export function activate(_context: vscode.ExtensionContext): void {
     void registerFtpApis();
 }
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-export function deactivate(context: vscode.ExtensionContext): void {
+export function deactivate(_context: vscode.ExtensionContext): void {
     sessionMap.forEach((session) => session.releaseConnections());
     sessionMap.clear();
 }

packages/zowe-explorer/CHANGELOG.md

@@ -6,7 +6,8 @@ All notable changes to the "vscode-extension-for-zowe" extension will be documen
 
 ### New features and enhancements
 
-- Added Job search label to the Jobs tree. Label will show current search query [2062](https://github.com/zowe/vscode-extension-for-zowe/pull/2064).
+- Added Job search label to the Jobs tree. Label will show current search query [#2062](https://github.com/zowe/vscode-extension-for-zowe/pull/2064).
+- Added feature copy datasets ( pds, sequential, members across pds) with multi select capabilities. [#1150](https://github.com/zowe/vscode-extension-for-zowe/issues/1550)
 
 ### Bug fixes
 

packages/zowe-explorer/__tests__/__integration__/USSTree.integration.test.ts

@@ -213,7 +213,6 @@ describe("USSTree Integration Tests", async () => {
      *************************************************************************************************************/
     it("Tests the addSession() function by adding a default, deleting, then adding a passed session", async () => {
         let len = testTree.mSessionNodes.length;
-        const log = new imperative.Logger(undefined);
         await testTree.addSession();
         expect(testTree.mSessionNodes.length).toBeGreaterThanOrEqual(len + 1);
         len = testTree.mSessionNodes.length;

packages/zowe-explorer/__tests__/__integration__/extension.integration.test.ts

@@ -455,8 +455,9 @@ describe("Extension Integration Tests", async () => {
                     try {
                         const fromNode = new ZoweDatasetNode(fromDataSetName, vscode.TreeItemCollapsibleState.None, sessionNode, session);
                         const toNode = new ZoweDatasetNode(toDataSetName, vscode.TreeItemCollapsibleState.None, sessionNode, session);
+                        const nodeList: ZoweDatasetNode[] = [fromNode];
+                        await dsActions.copyDataSets(nodeList, null, null);
 
-                        await dsActions.copyDataSet(fromNode);
                         await dsActions.pasteMember(toNode, testTree);
 
                         contents = await zowe.Get.dataSet(sessionNode.getSession(), fromDataSetName);
@@ -496,7 +497,6 @@ describe("Extension Integration Tests", async () => {
 
                         const inputBoxStub = sandbox.stub(vscode.window, "showInputBox");
                         inputBoxStub.returns(toMemberName);
-
                         await dsActions.copyDataSet(fromNode);
                         await dsActions.pasteMember(parentNode, testTree);
 
@@ -546,8 +546,8 @@ describe("Extension Integration Tests", async () => {
 
                         const inputBoxStub = sandbox.stub(vscode.window, "showInputBox");
                         inputBoxStub.returns(toMemberName);
-
-                        await dsActions.copyDataSet(fromNode);
+                        const nodeList: ZoweDatasetNode[] = [fromNode];
+                        await dsActions.copyDataSets(nodeList, null, null);
                         await dsActions.pasteMember(toNode, testTree);
 
                         contents = await zowe.Get.dataSet(sessionNode.getSession(), `${toDataSetName}(${toMemberName})`);
@@ -597,8 +597,8 @@ describe("Extension Integration Tests", async () => {
                         fromParentNode.contextValue = globals.DS_PDS_CONTEXT;
                         fromMemberNode.contextValue = globals.DS_MEMBER_CONTEXT;
                         toNode.contextValue = globals.DS_DS_CONTEXT;
-
-                        await dsActions.copyDataSet(fromMemberNode);
+                        const nodeList: ZoweDatasetNode[] = [fromMemberNode];
+                        await dsActions.copyDataSets(nodeList, null, null);
                         await dsActions.pasteMember(toNode, testTree);
 
                         contents = await zowe.Get.dataSet(sessionNode.getSession(), toDataSetName);

packages/zowe-explorer/__tests__/__integration__/index.ts

@@ -53,6 +53,7 @@ export function run(): Promise<void> {
                     }
                 });
             } catch (err) {
+                // eslint-disable-next-line no-console
                 console.error(err);
                 e(err);
             }

packages/zowe-explorer/__tests__/__integration__/runTest.ts

@@ -26,6 +26,7 @@ async function main() {
         // Download VS Code, unzip it and run the integration test
         await runTests({ extensionDevelopmentPath, extensionTestsPath });
     } catch (err) {
+        // eslint-disable-next-line no-console
         console.error("Failed to run tests");
         process.exit(1);
     }

packages/zowe-explorer/__tests__/__theia__/index.ts

@@ -53,6 +53,7 @@ export function run(): Promise<void> {
                     }
                 });
             } catch (err) {
+                // eslint-disable-next-line no-console
                 console.error(err);
                 e(err);
             }

packages/zowe-explorer/__tests__/__theia__/runTest.ts

@@ -26,6 +26,7 @@ async function main() {
         // Download VS Code, unzip it and run the integration test
         await runTests({ extensionDevelopmentPath, extensionTestsPath });
     } catch (err) {
+        // eslint-disable-next-line no-console
         console.error("Failed to run tests");
         process.exit(1);
     }