Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use new caa location to configmgr #497

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

1000TurquoisePogs
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs commented Oct 22, 2024

Other build scripts have been using "-DNEW_CAA_LOCATIONS=1" but not configmgr.
I believe this should allow configmgr to work with heappools being on, without any drawbacks.

How to test:

Before:

 _CEE_RUNOPTS="HEAPPOOLS(ON),HEAPPOOLS64(ON)" ./configmgr -h
CEE3204S The system detected a protection exception (System Completion Code=0C4).
         From compile unit ZZOW08:/ZOWE/tmp/pax-packaging-configmgr-1723644907470/content/build/../c/logging.c at entry point logConfigureDestination at statement 436 at compile unit offset +000000003C6B6C56 at entry offset +00000000000001CE at address
         000000003C6B6C56.
Segmentation fault

After:

_CEE_RUNOPTS="HEAPPOOLS(ON),HEAPPOOLS64(ON)" ./configmgr -h

 *** unknown option *** '-h'
Usage:
  configmgr [options] <command> <args>
    options
      -h                  : show help
      -script <path>      : quickjs-compatible javascript file to run with configmgr utilities
      -t <level>          : enable tracing with level from 1-3
      -o <outStream>      : OUT|ERR , ERR is default
      -s <path:path...>   : <topSchema>(:<referencedSchema)+
      -w <path>           : workspace directory
      -c                  : compact output for jq and extract commands
      -r                  : raw string output for jq and extract commands
      -m <memberName>     : member name to find the zowe config in each PARMLIBs specified
      -p <configPath>     : list of colon-separated configPathElements - see below
    commands:
      extract <jsonPath>  : prints value to stdout
      validate            : just loads and validates merged configuration
      env <outEnvPath>    : prints merged configuration to a file as a list of environment vars
    configPathElement:
      PARMLIB(datasetName) - a library that can contain config data
      FILE(filename)   - the name of a file containing Yaml
      PARMLIBS         - all PARMLIBS that are defined to this running Program in ZOS, nothing if not on ZOS

Signed-off-by: 1000TurquoisePogs <[email protected]>
Copy link
Contributor

@Martin-Zeithaml Martin-Zeithaml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same results on our system:

  • "Segmentation fault" without fix
  • No problem when compiled with DNEW_CAA_LOCATIONS

@JoeNemo JoeNemo merged commit 4d91ad9 into v3.x/staging Oct 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants