Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for min and max tls #411

Merged
merged 11 commits into from
Nov 22, 2023
Merged

Conversation

1000TurquoisePogs
Copy link
Member

This PR uses the schema in zowe/zowe-install-packaging#3509 to allow users to more easily customize network attributes for TLS level.

CHANGELOG: Added support for using "zowe.network" and "components.zss.zowe.network" to set TLS version properties.
VERSION: 2.13.0

How to test: You can customize what version of TLS firefox listens for, as well as view what version was used when connecting, so you can set different TLS levels and observe them through firefox.

Signed-off-by: 1000TurquoisePogs <[email protected]>
zowe-robot and others added 8 commits October 24, 2023 12:58
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
c/tls.c Outdated
zowelog(NULL, LOG_COMP_HTTPSERVER, ZOWE_LOG_DEBUG, "TLS 1.0 off\n");
rc = rc || gsk_attribute_set_enum(env->envHandle, GSK_PROTOCOL_TLSV1, GSK_PROTOCOL_TLSV1_OFF);
}
if (tlsMin <= TLS_V1_1 && tlsMax >= TLS_V1_1) {
Copy link
Member Author

@1000TurquoisePogs 1000TurquoisePogs Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave out tls 1.1 and tls 1.0

Signed-off-by: 1000TurquoisePogs <[email protected]>
Copy link
Contributor

@JoeNemo JoeNemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@1000TurquoisePogs 1000TurquoisePogs merged commit 0c7a6b8 into v2.x/staging Nov 22, 2023
7 checks passed
@1000TurquoisePogs 1000TurquoisePogs deleted the feature/v2/check-min-max-tls branch November 28, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants