String handling performance improvement #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveyc
force-pushed
the
string-handling-performance-improvement
branch
from
cefd34d
to
1c42e9a
Compare
daveyc
force-pushed
the
string-handling-performance-improvement
branch
2 times, most recently
from
fe8d511
to
1c4dff7
Compare
Signed-off-by: David Crayford <[email protected]>
daveyc
force-pushed
the
string-handling-performance-improvement
branch
from
1c4dff7
to
cb4fb24
Compare
Signed-off-by: David Crayford <[email protected]>
daveyc
force-pushed
the
string-handling-performance-improvement
branch
from
93914ad
to
d8c933f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of indexOfString by an order of magnitude for long strings.