Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use zowe standard network config #284

Merged

Conversation

1000TurquoisePogs
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs commented Oct 11, 2023

This PR uses the schema in zowe/zowe-install-packaging#3509 to allow users to more easily customize network attributes for IP and TLS level.

CHANGELOG: Added support for using "zowe.network" and "components.app-server.zowe.network" to set listener IP and TLS version properties.
VERSION: 2.13.0

How to test:

  1. set the log level to see debug output that shows you that it is working
components:
  app-server:
    logLevels:
    - _zsf.bootstrap: 3
  1. IP: change zowe.network.server.listenAddresses to an array of 1 ip, and you will see that IP on message
  2. IP: change components.app-server.zowe.network.server.listenAddresses to a different ip, and you will see that this would override 1)
  3. Ciphers: see the cipher list in the debug printout (ex A:B:C). Check which one is used by Zowe when you go to Zowe in Firefox
    image
  4. Ciphers: Shorten the list you saw to remove the one you saw in firefox (ex, C). Then turn it into an array, ex
zowe:
  network:
    server:
      tls:
        ciphers:
        - A
        - B

you should then see it not in the debug messages, and that firefox uses a different cipher.

  1. tls version: change zowe.network.server.tls.minTls and zowe.network.server.tls.maxTls to different combinations of "TLSv1.2" and "TLSv1.3"
    For TLS, you can customize what version of TLS firefox listens for, as well as view what version was used when connecting, so you can set different TLS levels and observe them through firefox.

in the URL "about:config", you can customize tls levels for firefox: https://kb.mozillazine.org/Security.tls.version.*

I have tested that app-server does respect the minTls / maxTls settings in this way, because if I configure it to do only tls 1.3, I see this message:
image

I do not have a test for curves. it would be similar to ciphers though.

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Fix typo (networking -> network)

Signed-off-by: 1000TurquoisePogs <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 16, 2023
@1000TurquoisePogs 1000TurquoisePogs merged commit ac02cf3 into v2.x/staging Nov 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants