-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reject PR if identical to pull_request_template.md #281
base: v2.x/staging
Are you sure you want to change the base?
Conversation
Signed-off-by: hpathak <[email protected]>
Signed-off-by: Himani1519 <[email protected]>
Signed-off-by: Himani1519 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a reasonable approach to the template problem, but you put it inside of "extract-changelog"
can you please put it into its own step so it is clear that these are 2 different tasks
Signed-off-by: Himani1519 <[email protected]>
…into feature/update_changelog_action
Signed-off-by: Himani1519 <[email protected]>
Signed-off-by: Himani1519 <[email protected]>
…into feature/update_changelog_action
Signed-off-by: Himani1519 <[email protected]>
.github/workflows/build-core.yml
Outdated
echo "PR DESCRIPTION saved to /tmp/pr_description.txt." | ||
|
||
# Save the template content to a file without modifying it | ||
cat .github/pull_request_template.md > /tmp/template_content.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no reason to do this? it's already a file.
.github/workflows/build-core.yml
Outdated
|
||
|
||
# Use diff to compare the two files | ||
if diff -wB /tmp/pr_description.txt /tmp/template_content.txt > /dev/null; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just diff .github/pull_request_template.md directly.
Signed-off-by: 1000TurquoisePogs <[email protected]>
Move to node-base changelog setting
Proposed changes
This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments