Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking page updates #265

Open
wants to merge 6 commits into
base: v2.x/staging
Choose a base branch
from

Conversation

skurnevich
Copy link
Collaborator

@skurnevich skurnevich commented Nov 1, 2024

A few updates to the Networking tab

  • updated page UI, removed excessive component properties
  • removed hardcoded server-base schema
  • removed some unused parts like ajv validation
  • added zowe.network support with limitation in form of hardcoded schema section, as JsonForms can't process our schema
  • minor code clean up and linter errors fix for Networking.tsx

Screenshot 2024-11-05 at 10 37 49

Signed-off-by: Sergei Kurnevich <[email protected]>
Signed-off-by: Sergei Kurnevich <[email protected]>
Signed-off-by: Sergei Kurnevich <[email protected]>
Signed-off-by: Sergei Kurnevich <[email protected]>
Signed-off-by: Sergei Kurnevich <[email protected]>
@skurnevich skurnevich changed the title WIP: Networking page updates Networking page updates Nov 4, 2024
@sakshibobade21
Copy link
Contributor

Hello Sergei, thank you for the PR. It includes significant updates to the Networking stage.

However, I noticed a few regressions:

  1. The status of the Networking stage is not being stored correctly.
  2. After successfully completing the Networking stage, if you return to it later, the status automatically changes, and the green check mark is removed.
  3. Both the "Skip" and "Continue" buttons at the bottom are enabled simultaneously. Since the stage is already completed, the "Skip" button should be disabled.

Another issue I observed:
The Networking stage shows as successful even when the external domain, port, and max/min TLS fields are left empty.

Related screenshots;

image (48)
image (47)
image (46)

@sakshibobade21
Copy link
Contributor

I will be further testing the PR. Thank you?

@Himani1519
Copy link
Contributor

Hi Sergei, I noticed one more regression.
1.Updating the value in the YAML editor is not reflecting in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants