Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cors enabled in default mode with AT-TLS profile #3221

Merged
merged 16 commits into from
Dec 1, 2023
Merged

Cors enabled in default mode with AT-TLS profile #3221

merged 16 commits into from
Dec 1, 2023

Conversation

pablocarle
Copy link
Contributor

Description

CORS validation is handled by Gateway according to the service registration metadata. Catalog has CORS enabled by default. This configuration allows for AT-TLS to allow all origins by default (can be configured for the service in allowed origins anyway)

Linked to #2795

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

enable cors in attls mode
6537266 
Signed-off-by: Pablo Hernán Carle <[email protected]>
wip attls allowed origin
283ebe8 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@pablocarle pablocarle changed the title Cors enabled in default mode (allow everything) with AT-TLS profile Cors enabled in default mode with AT-TLS profile Nov 28, 2023
update to correct environment variable
b84f181 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Nov 29, 2023
Pablo Hernán Carle and others added 9 commits November 29, 2023 16:29
wip cors configuration, update start.sh scripts
b3c8143 
Signed-off-by: Pablo Hernán Carle <[email protected]>
fix message
a1adef5 
Signed-off-by: Pablo Hernán Carle <[email protected]>
fix sonar, missing coverage
a165774 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@pablocarle
Merge branch 'v2.x.x' into reboot/fix/attls-cors
aa38955
add test for coverage
8af3fde 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@pj892031
add logging message
c81428f
disable test run in publish result stage
4cccadd 
Signed-off-by: Pablo Hernán Carle <[email protected]>
wip
ff592f5 
Signed-off-by: Pablo Hernán Carle <[email protected]>
@pj892031
fix the test
a6eddee
Pablo Hernán Carle and others added 2 commits December 1, 2023 13:42
@pablocarle @pj892031
Update gateway-service/src/test/java/org/zowe/apiml/gateway/metadata/…
bfffd5a 
…service/CorsMetadataProcessorTest.java

Co-authored-by: Pavel Jareš <[email protected]>
Signed-off-by: Pablo Carle <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

91.9% 91.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pablocarle pablocarle merged commit 047ec14 into v2.x.x Dec 1, 2023
32 checks passed
@nxhafa nxhafa deleted the reboot/fix/attls-cors branch August 30, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achmelo achmelo achmelo left review comments

@pj892031 pj892031 pj892031 approved these changes

Assignees
No one assigned
Labels
Sensitive Sensitive change that requires peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablocarle @achmelo @pj892031