Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update EhCache V2 #3102

Merged
merged 4 commits into from
Oct 3, 2023
Merged

chore: Update EhCache V2 #3102

merged 4 commits into from
Oct 3, 2023

Conversation

pj892031
Copy link
Contributor

Description

This PR is a copy of #3098 for v2:

The APIML used EhCache library version 2 which is not supported anymore. The old JAR file contains also some libraries. Those libraries are also obsolete and contain vulnerabilities.

This PR upgrades EhCache to version 3 - it solves old dependencies (without any support) and removes dependencies with vulnerabilities from the final PAX file.

Linked to # (issue)
Part of the # (epic)

Type of change

Please delete options that are not relevant.

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Change in a documentation
  • refactor: Refactor the code
  • chore: Chore, repository cleanup, updates the dependencies.
  • BREAKING CHANGE or !: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • PR title conforms to commit message guideline ## Commit Message Structure Guideline
  • I have commented my code, particularly in hard-to-understand areas. In JS I did provide JSDoc
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The java tests in the area I was working on leverage @nested annotations
  • Any dependent changes have been merged and published in downstream modules

For more details about how should the code look like read the Contributing guideline

Signed-off-by: Pavel Jareš <[email protected]>
@github-actions github-actions bot added the Sensitive Sensitive change that requires peer review label Sep 26, 2023
@pj892031 pj892031 marked this pull request as ready for review September 26, 2023 14:32
Copy link
Member

@achmelo achmelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also an increase in the number of log messages coming from eh cache library.

@pj892031 pj892031 requested a review from achmelo October 3, 2023 13:23
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pj892031 pj892031 merged commit f0ac1e7 into v2.x.x Oct 3, 2023
30 checks passed
@delete-merged-branch delete-merged-branch bot deleted the reboot/ehcache_v2 branch October 3, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sensitive Sensitive change that requires peer review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants