Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OFS/dtml/cacheable: Remove "New" from label #1232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OFS/dtml/cacheable: Remove "New" from label #1232

wants to merge 1 commit into from

Conversation

perrinjerome
Copy link
Contributor

In 6ac52aa#diff-1cd7357f6a0c6126e3279998f27d3c17f5d48e4940356bbe6f0266101828fb02R9 the label was changed from Cache this object using to New Cache this object using, this looks like left-overs from debugging.

@perrinjerome
OFS/dtml/cacheable: Remove "New" from label
402d59c 
In 6ac52aa#diff-1cd7357f6a0c6126e3279998f27d3c17f5d48e4940356bbe6f0266101828fb02R9
the label was changed from `Cache this object using` to `New Cache this
object using`, this looks like left-overs from debugging.
@perrinjerome
Copy link
Contributor Author

sorry, test is failing on OSX because of a problem installing packages, it does not look related.

@perrinjerome
Copy link
Contributor Author

Thank you for review, I submitted a fix for tests in #1234 I'll rebase this and merge once the tests are fixed (I can not merge now because of required status)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataflake dataflake dataflake approved these changes

@drfho drfho drfho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perrinjerome @dataflake @drfho