Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to filtering and handling of non-patchable keys in Virtual Service #1526

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Improvements to filtering and handling of non-patchable keys in Virtual Service #1526

wants to merge 8 commits into from

Conversation

StarKhan6368
Copy link
Collaborator

What: Improvements to filtering and handling of non-patchable keys in Virtual Service

How:

  • On any attempts made to patch a non-patchable key with a new value, the server will respond with a 4xx response and will not silently ignore the value being patched.
  • The values in attribute filtering are now being validated against their corresponding keys in the response schemas.
  • Attribute filtering is now possible on extensible keys, which are not defined in the spec but present in examples when extensible schema is enabled.

Checklist:

@StarKhan6368
Non-patchable key errors should result in 422 response.
d3eb6f1 
- When a non-patchable key is being patched with a new value VS should
  return a 422 error response or fallback to 400
@StarKhan6368
Should be able to filter on extended keys.
2243396
@StarKhan6368
Change non-patchable fallback to 409 instead of 400
048f573
@StarKhan6368
modify attribute filtering logic in stateful vs.
3eceeb0
@StarKhan6368
Implement Attribute filtering values validation
cdd7c82 
- The value being filtered on will be validated based on the
  response pattern for the key being filtered.
@StarKhan6368
Fix attribute filter validation breadCrumbs
7556ed6
@StarKhan6368
attribute selection AnyPattern validation improvements
ebf6d8c 
- Validate against all key patterns from all patterns of an AnyPattern
  instead of just choosing the first one that has the key.
@StarKhan6368
Add missing asserts and breadCrumb on attribute filtering
f3acbc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StarKhan6368