test: stable brod_group_subscriber_SUITE:t_async_commit

zmstone · Jun 18, 2024 · d5e92b4 · d5e92b4
1 parent 28a3a2e
commit d5e92b4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/test/brod_group_subscriber_SUITE.erl b/test/brod_group_subscriber_SUITE.erl
@@ -550,6 +550,7 @@ t_async_commit({init, Config}) ->
                            integer_to_list(rand:uniform(1000000000))),
   [{group_id, GroupId} | Config];
 t_async_commit(Config) when is_list(Config) ->
+  GroupId = ?config(group_id),
   Behavior = ?config(behavior),
   Topic = ?topic,
   Partition = 0,
@@ -562,7 +563,7 @@ t_async_commit(Config) when is_list(Config) ->
                          , {partition_restart_delay_seconds, 1}
                          , {begin_offset, Offset}
                          ],
-        {ok, SubscriberPid} = start_subscriber(?group_id, Config, [Topic],
+        {ok, SubscriberPid} = start_subscriber(GroupId, Config, [Topic],
                                                GroupConfig, ConsumerConfig,
                                                InitArgs),
         SubscriberPid

diff --git a/test/brod_topic_subscriber_SUITE.erl b/test/brod_topic_subscriber_SUITE.erl
@@ -211,7 +211,7 @@ t_consumer_ack_via_message_passing(Config) when is_list(Config) ->
   Partition = 0,
   SendFun =
     fun(I) ->
-        produce({?topic, Partition}, <<I>>)
+        produce({?topic, Partition}, integer_to_binary(I))
     end,
   ?check_trace(
      %% Run stage:
@@ -225,12 +225,12 @@ t_consumer_ack_via_message_passing(Config) when is_list(Config) ->
        {ok, SubscriberPid} =
          brod:start_link_topic_subscriber(?CLIENT_ID, ?topic, ConsumerConfig,
                                           ?MODULE, InitArgs),
-      {ok, _} = wait_message(<<1>>),
+      {ok, _} = wait_message(<<"1">>),
       %% ack_offset allows consumer to proceed to message 2
       SubscriberPid ! {ack_offset, 0, Offset0},
-      {ok, _} = wait_message(<<2>>),
+      {ok, _} = wait_message(<<"2">>),
        ok = brod_topic_subscriber:stop(SubscriberPid),
-       _Expected = [<<1>>, <<2>>]
+       _Expected = [<<"1">>, <<"2">>]
      end,
      %% Check stage:
      fun(Expected, Trace) ->