feat(boards): add nrf52 nosd snippets #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on a Jorne with an nRF52833 nrfmicro. |
krikun98
force-pushed
the
nrf52833-nosd-snippet
branch
from
c2fcd59
to
a999598
Compare
krikun98
force-pushed
the
nrf52833-nosd-snippet
branch
3 times, most recently
from
54541d9
to
6a3f9ea
Compare
caksoylar
reviewed
Oct 10, 2024
krikun98
force-pushed
the
nrf52833-nosd-snippet
branch
2 times, most recently
from
5708f26
to
caa1368
Compare
krikun98
force-pushed
the
nrf52833-nosd-snippet
branch
from
caa1368
to
82e648a
Compare
caksoylar
approved these changes
Oct 10, 2024
petejohanson
requested changes
Oct 10, 2024
Nick-Munnich
approved these changes
Oct 10, 2024
krikun98
force-pushed
the
nrf52833-nosd-snippet
branch
from
82e648a
to
74f1895
Compare
|
@caksoylar, @Nick-Munnich, I added |
krikun98
force-pushed
the
nrf52833-nosd-snippet
branch
from
74f1895
to
6bf2cf4
Compare
krikun98
changed the title
krikun98
force-pushed
the
nrf52833-nosd-snippet
branch
from
6bf2cf4
to
437fcdb
Compare
|
Is there a plan to add this snippet? It would be very helpful. |
Add snippet to build for nRF52833 boards while ignoring the SoftDevice. This is necessary as those boards are memory-constrained.
Add snippet to build for nRF52840 boards while ignoring the SoftDevice. This might be useful for especially memory-intensive applications.
krikun98
force-pushed
the
nrf52833-nosd-snippet
branch
from
437fcdb
to
ac18eba
Compare
petejohanson
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add snippet to build for nRF52833/52840 boards while ignoring the SoftDevice. This is necessary as nRF52833 boards are memory-constrained and nRF52840 boards can accidentally erase the SoftDevice.
Board/Shield Check-list