feat: Tweaks for reduced nanopb stack usage. #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petejohanson
added
enhancement
|
Do you intend to try to upstream the nanopb changes or just keep maintaining a fork of it? |
Here's my attempt: nanopb/nanopb#1016 |
* Reduced stack size.
petejohanson
force-pushed
the
studio/move-to-optimized-nanopb
branch
from
7acd597
to
1797de8
Compare
|
Ok, need to do this in mulpitle phases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on some tweaks to reduce our stack usage for our RPC stack, in particular with some tweaks to nanopb that bring it's stack size usage down.
See zmkfirmware/nanopb@bf32817 for the change to nanopb (which we now have a fork of) and the small changes to Zephyr that I'll merge into our fork when we're happy.
With this change, on USB on stm32f072, I can drop the RPC stack size to 2048 and have enough wiggle room to space (normal usage seems to go up to 1700 bytes or so).
Needs more testing, but the nanopb code changes are fairly innocuous.