Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(studio): Update position map querying #2487

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

awkannan
Copy link
Contributor

DT_HAS_COMPAT_STATUS_OKAY expects a compatible, what we actually want to do is check if the physical layout node in a position map is compatible with zmk_physical_layout and in ok status.

For that, we'd use DT_NODE_HAS_COMPAT_STATUS but COND_CODE_1 only supports functions with one or two args, so we have to use UTIL_AND to accomplish the same behavior.

@awkannan awkannan requested a review from a team as a code owner September 18, 2024 01:01
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here with the posix MiniVan, and also confirmed that disabling one of the layouts there still works as expected. Thanks for the fix!

@petejohanson petejohanson merged commit c8c8835 into zmkfirmware:main Sep 18, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants