feat(behaviors): Turbo Key #1414
Conversation
nickconway
force-pushed
the
turbo-key
branch
2 times, most recently
from
e42c8ba
to
d38b4d3
Compare
docs/docs/behaviors/turbo.md
Outdated
|
|
||
| ## Summary | ||
|
|
||
| The turbo behavior will repeatedly trigger a behavior after a specified amount of time. |
There was a problem hiding this comment.
I am a bit unclear on how exactly this works and it would be good to clarify further here. I think by default, (no toggle term) it only repeats while the key is held, and cancels repeating when it is released, is it?
But if toggle term is set and tap duration is shorter than that, it stays active and the next press cancels it?
|
|
||
| LOG_DBG("%d started new turbo", event.position); | ||
| data->press_time = k_uptime_get(); | ||
| k_work_init_delayable(&data->release_timer, behavior_turbo_timer_handler); |
There was a problem hiding this comment.
This should be initialized in the init function for the behavior instance, not every time here.
| zmk_behavior_queue_add(event.position, cfg->binding, true, cfg->tap_ms); | ||
| zmk_behavior_queue_add(event.position, cfg->binding, false, 0); |
There was a problem hiding this comment.
This is a little duplicated from the same code in the timer handler, Can we pull that out to avoid duplication?
|
|
||
| #define _TRANSFORM_ENTRY(idx, node) \ | ||
| { \ | ||
| .behavior_dev = DT_LABEL(DT_INST_PHANDLE_BY_IDX(node, bindings, idx)), \ |
There was a problem hiding this comment.
Needs to be refactored to:
| .behavior_dev = DT_LABEL(DT_INST_PHANDLE_BY_IDX(node, bindings, idx)), \ | |
| .behavior_dev = DT_PROP(DT_INST_PHANDLE_BY_IDX(node, bindings, idx), label), \ |
For some Zephyr changes.
| int tap_ms; | ||
| int wait_ms; | ||
| struct zmk_behavior_binding binding; | ||
|
|
There was a problem hiding this comment.
I don't see any reason this is duplicated in the data, and in the config. Should just be in the config?
| tap-ms = <5>; | ||
| wait-ms = <300>; | ||
| toggle-term-ms = <50>; | ||
| bindings = <&kp C>; |
There was a problem hiding this comment.
Is there any reason we couldn't "parameterize" this the same way we did for macros recently? Seems a shame to force a new turbo for every keycode you want to use like this, for instance.
nickconway
force-pushed
the
turbo-key
branch
from
d38b4d3
to
c2f2f37
Compare
Functionality for continuous repeating of any behavior.