-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print per-second summary statistics detailing a scan, similar to ZMap #473
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's OK to make this not disable'able or not redirectable. I also don't think that it's OK to put these on stdout
since it precludes piping ZDNS into another program. These should be able to be turned on and off and should be printed to stderr or a file.
The most useful thing in ZMap to make sure a scan looks good is hitrate, which you can't actually quite get here. Can we get the same thing here. When calculating hitrate I would include both NOERROR
and NXDOMAIN
because both are a successful response from the DNS server.
Yep all seems reasonable! Will make those changes |
Closes #472
Adds a per-second summary with the following:
A final summary is printed on scan completion
This is printed to stderr by default.
Two new CLI flags are available to modify this behavior:
Demo