Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOVA Scotia folding scheme test done #227 #240

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e3041ff
Add Nova Scotia Packages
timou0911 Sep 14, 2024
2341cd6
Add Nova Scotia Packages
timou0911 Sep 14, 2024
30d9626
Add Nova Scotia Dependencies
timou0911 Sep 14, 2024
09d5e38
Add Nova Scotia Dependencies
timou0911 Sep 14, 2024
5df1c71
Add Nova Scotia Features
timou0911 Sep 14, 2024
86e8741
Add Nova Scotia
timou0911 Sep 14, 2024
a0caffe
Change Return Type
timou0911 Sep 14, 2024
6209b73
Change Return Type
timou0911 Sep 14, 2024
c67d5bf
Add toy example
timou0911 Sep 14, 2024
ebd31f0
nova_scotia test with error(22)
csiejimmyliu Sep 14, 2024
761c7f0
nova_scotia test with error(19)
csiejimmyliu Sep 14, 2024
2157b15
Fixing Errors(10)
timou0911 Sep 14, 2024
8f472dc
nova_scotia test with error(2): verify_nova_scotia_proof return type
csiejimmyliu Sep 14, 2024
b91fbce
test able to build (not compressed yet)
csiejimmyliu Sep 14, 2024
b471ca2
test fail (can't reproduce sample code yet)
csiejimmyliu Sep 15, 2024
8e68452
test pass with bn256_grumpkin(not compress yet)
csiejimmyliu Sep 15, 2024
7c46b20
test pass with bn256_grumpkin, compress done
csiejimmyliu Sep 16, 2024
220cabc
remove unuse import
csiejimmyliu Sep 19, 2024
805b0b2
comments done
csiejimmyliu Sep 21, 2024
0b6d0b7
Merge branch 'zkmopro:main' into main
csiejimmyliu Sep 21, 2024
c03face
rename circuit, remove temporary files, CI script, enable dependencies
csiejimmyliu Sep 25, 2024
f478b51
dev dependencies test
csiejimmyliu Sep 25, 2024
298f972
optional dependencies
csiejimmyliu Sep 26, 2024
a7bbad4
move above dev dependencies
csiejimmyliu Sep 26, 2024
9450c94
solve the NovaScotiaError problem
june-in-exile Oct 7, 2024
a3db961
try some brutal way to fix the import problem but fails
june-in-exile Oct 8, 2024
9e013be
update github action
june-in-exile Oct 8, 2024
4e0aa50
update nova_scotia_app! to make it testable
june-in-exile Oct 8, 2024
61eab82
refactor by adding nova_scotia_types.rs
june-in-exile Oct 8, 2024
103dd13
sorry I forgot to lint
june-in-exile Oct 8, 2024
86cf7ca
refactor for better readability
june-in-exile Oct 8, 2024
89b6b4c
remove type
june-in-exile Oct 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Build and Test

on:
push:
branches:
- '*'
pull_request:
types:
- opened
Expand Down Expand Up @@ -46,6 +48,18 @@ jobs:
override: true
- name: Run ffi circom tests
run: cd mopro-ffi && cargo test --features circom --no-default-features
test-ffi-nova_scotia:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we align the usage of - and _
I prefer the feature flag be nova-scotia
e.g. --features nova-scotia
(but in rust code some place needs to be nova_scotia then just keep them nova_scotia)

runs-on: ubuntu-latest
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
steps:
- uses: actions/checkout@v4
- name: Install Rust toolchain
uses: actions-rs/toolchain@v1
with:
toolchain: stable
override: true
- name: Run ffi nova_scotia tests
run: cd mopro-ffi && cargo test --features nova_scotia --no-default-features
test-e2e:
runs-on: ubuntu-latest
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
Expand Down
Loading
Loading