-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOVA Scotia folding scheme test done #227 #240
Open
csiejimmyliu
wants to merge
32
commits into
zkmopro:main
Choose a base branch
from
csiejimmyliu:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
e3041ff
Add Nova Scotia Packages
timou0911 2341cd6
Add Nova Scotia Packages
timou0911 30d9626
Add Nova Scotia Dependencies
timou0911 09d5e38
Add Nova Scotia Dependencies
timou0911 5df1c71
Add Nova Scotia Features
timou0911 86e8741
Add Nova Scotia
timou0911 a0caffe
Change Return Type
timou0911 6209b73
Change Return Type
timou0911 c67d5bf
Add toy example
timou0911 ebd31f0
nova_scotia test with error(22)
csiejimmyliu 761c7f0
nova_scotia test with error(19)
csiejimmyliu 2157b15
Fixing Errors(10)
timou0911 8f472dc
nova_scotia test with error(2): verify_nova_scotia_proof return type
csiejimmyliu b91fbce
test able to build (not compressed yet)
csiejimmyliu b471ca2
test fail (can't reproduce sample code yet)
csiejimmyliu 8e68452
test pass with bn256_grumpkin(not compress yet)
csiejimmyliu 7c46b20
test pass with bn256_grumpkin, compress done
csiejimmyliu 220cabc
remove unuse import
csiejimmyliu 805b0b2
comments done
csiejimmyliu 0b6d0b7
Merge branch 'zkmopro:main' into main
csiejimmyliu c03face
rename circuit, remove temporary files, CI script, enable dependencies
csiejimmyliu f478b51
dev dependencies test
csiejimmyliu 298f972
optional dependencies
csiejimmyliu a7bbad4
move above dev dependencies
csiejimmyliu 9450c94
solve the NovaScotiaError problem
june-in-exile a3db961
try some brutal way to fix the import problem but fails
june-in-exile 9e013be
update github action
june-in-exile 4e0aa50
update nova_scotia_app! to make it testable
june-in-exile 61eab82
refactor by adding nova_scotia_types.rs
june-in-exile 103dd13
sorry I forgot to lint
june-in-exile 86cf7ca
refactor for better readability
june-in-exile 89b6b4c
remove type
june-in-exile File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we align the usage of
-
and_
I prefer the feature flag be
nova-scotia
e.g.
--features nova-scotia
(but in rust code some place needs to be
nova_scotia
then just keep themnova_scotia
)