Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.13.0 #40

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Release 0.13.0 #40

merged 1 commit into from
Dec 6, 2022

Conversation

str4d
Copy link
Member

@str4d str4d commented Dec 6, 2022

No description provided.

daira
daira approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d
Copy link
Member Author

str4d commented Dec 6, 2022

Hmm, I just remembered #32, and am now considering implementing the Group::identity() -> Group::IDENTITY change (but not Group::GENERATOR at this time, because that's not as obviously a single constant). I'll give it a quick go and see how much of a change it results in.

@str4d
Copy link
Member Author

str4d commented Dec 6, 2022

Results of my investigation are here: #32 (comment)

tl;dr we won't block this release on that change, because we need more time to investigate the ecosystem. We can make sure to work on it for group 0.14 instead.

@str4d str4d merged commit 090a7ec into main Dec 6, 2022
@str4d str4d deleted the release-0.13.0 branch December 6, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@str4d @daira