Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use tag type for calling convention #2057

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

ngynkvn
Copy link
Contributor

@ngynkvn ngynkvn commented Oct 24, 2024

Fix for 0.14.0-dev.1983+6bf52b050

std.builtin.CallingConvention was recently changed to union(enum(u8)), with some deprecated names as well. This swaps the field to be CallingConvention.Tag type instead and replaces the deprecated names with their equivalent

@ngynkvn
Copy link
Contributor Author

ngynkvn commented Oct 24, 2024

I guess I shouldn't have expected this to be so simple 🙃

====== expected this output: =========
fn() align(4) callconv(.C) type␃

======== instead found this: =========
fn() align(4) callconv(.aarch64_aapcs_darwin) type␃

======================================
First difference occurs on line 1:
expected:
fn() align(4) callconv(.C) type
                        ^ ('\x43')
found:
fn() align(4) callconv(.aarch64_aapcs_darwin) type
                        ^ ('\x61')

I pushed up another change to adjust the test cases to fit the type change I made, but I don't think this will make them pass as per above. Feel free to close this if I'm chasing a red herring / understanding this incorrectly.

ngynkvn and others added 4 commits October 25, 2024 00:54
Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/4eb33fe664af7b41a4c446f87d20c9a0a6321fa3' (2024-10-17)
  → 'github:NixOS/nixpkgs/32e940c7c420600ef0d1ef396dc63b04ee9cad37' (2024-10-23)
• Updated input 'zig-overlay':
    'github:mitchellh/zig-overlay/5aa48f75dcfd6a4f46bd6e0a1cb263652e25e4ec' (2024-10-19)
  → 'github:mitchellh/zig-overlay/0a4db4fe638db7838fb065680ebc92b7621b7990' (2024-10-24)
@Techatrix Techatrix merged commit 5acc066 into zigtools:master Oct 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants