implement new interrupt calling conventions in the llvm backend #21807
+64
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#16635 can maybe also be closed? Though not as a result of this PR specifically. |
alexrp
reviewed
Oct 26, 2024
| .value = .empty, | ||
| } }, &o.builder); | ||
| }, | ||
| .csky_interrupt => { |
There was a problem hiding this comment.
I guess you could merge this with the prong above? Doesn't really matter though.
alexrp
approved these changes
Oct 26, 2024
mlugg
reviewed
Oct 26, 2024
| std.builtin.CallingConvention.X86RegparmOptions => .{ pl.incoming_stack_alignment, pl.register_params }, | ||
| else => unreachable, | ||
| else => @compileError("TODO: toLlvmCallConv" ++ @tagName(pl)), |
There was a problem hiding this comment.
nit: don't try and be too fancy, comptime unreachable is fine :^)
There was a problem hiding this comment.
yeah fair enough, I just needed to see which callconv was the one I hadn't handled yet and I'm lazy. would you like me to use comptime unreachable here instead?
There was a problem hiding this comment.
Feel free to change it, but it's not a problem, just thought I'd mention
Comment on lines
+3109
to
+3118
| inline .avr_interrupt, .avr_signal => |_, tag| { | ||
| try attributes.addFnAttr(.{ .string = .{ | ||
| .kind = try o.builder.string(switch (tag) { | ||
| .avr_interrupt => "interrupt", | ||
| .avr_signal => "signal", | ||
| else => unreachable, | ||
| }), | ||
| .value = .empty, | ||
| } }, &o.builder); | ||
| }, |
There was a problem hiding this comment.
Don't use inline unnecessarily:
Suggested change
| inline .avr_interrupt, .avr_signal => |_, tag| { | |
| try attributes.addFnAttr(.{ .string = .{ | |
| .kind = try o.builder.string(switch (tag) { | |
| .avr_interrupt => "interrupt", | |
| .avr_signal => "signal", | |
| else => unreachable, | |
| }), | |
| .value = .empty, | |
| } }, &o.builder); | |
| }, | |
| .avr_interrupt, .avr_signal => { | |
| try attributes.addFnAttr(.{ .string = .{ | |
| .kind = try o.builder.string(switch (fn_info.cc) { | |
| .avr_interrupt => "interrupt", | |
| .avr_signal => "signal", | |
| else => unreachable, | |
| }), | |
| .value = .empty, | |
| } }, &o.builder); | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20671
closes #21805
anyone know of other issues this closes?
adds support for:
riscv64_interruptriscv32_interruptmips_interruptmips64_interruptarm_interruptcsky_interrupt