Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request latency log escalation #31

Merged
merged 4 commits into from
May 2, 2024

Conversation

jlsherrill
Copy link
Contributor

This adds the ability to specify a duration and a log level within the config. If a given request takes longer than the specified duration, it will be logged at this new level.

This adds the ability to specify a duration and a log level
within the config.  If a given request takes longer than the specified
duration, it will be logged at this new level.
@ziflex
Copy link
Owner

ziflex commented May 1, 2024

Hi @jlsherrill thank you for your PR!

Could you add test coverage and the description of the new settings to README.md, please?

@jlsherrill
Copy link
Contributor Author

added!

@ziflex
Copy link
Owner

ziflex commented May 1, 2024

Great!
I apologize, you had seen my message before I edited it.
Could you, please, add unit tests as well?

@jlsherrill
Copy link
Contributor Author

added, let me know if you want me to break that test up into two

@ziflex
Copy link
Owner

ziflex commented May 1, 2024

That would be nice.

@jlsherrill
Copy link
Contributor Author

test is now split

@jlsherrill
Copy link
Contributor Author

oh and hi from Cary !

@ziflex ziflex merged commit d00cbe5 into ziflex:master May 2, 2024
5 checks passed
@ziflex
Copy link
Owner

ziflex commented May 2, 2024

Hello from Raleigh and thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants