Fix running tests by directory #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code here didn't work, we returned early but with the wrong format. The calling code in neotest interpreted this as "unsupported" and so would itself run tests for every file it knows of. This implements running multiple files very similar to how Rake::TestTask does.
|
Thanks for the contributions! 🚀 |
ippachi
pushed a commit
to ippachi/neotest-minitest
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
Previously the code here didn't work, we returned early but with the wrong format. The calling code in neotest interpreted this as "unsupported" and so would itself run tests for every file it knows of.
This implements running multiple files very similar to how Rake::TestTask does, passing the files via ARGV and adding a
-escript torequireeach file passed.With this we run all test files in the directory in a single process rather than booting once for each file.