Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1ms delay to data loop. #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

1ms delay to data loop. #75

wants to merge 1 commit into from

Conversation

phuein
Copy link

@phuein phuein commented Apr 24, 2019

Overloads the CPU otherwise. The While loop should at least take 1ms.

Overloads the CPU otherwise. The While loop should at least take 1ms.
@phuein
Copy link
Author

phuein commented Apr 24, 2019

#65 Discussion

@jagprog5
Copy link

👍

@gaafiz
Copy link

gaafiz commented Mar 19, 2020

Is this going to be merged?

@barrettford
Copy link

So... we gonna merge this?

@SpotlightKid
Copy link

This is not the right way to fix this, IMO. The sleep does not belong in the _do_iter method. Just put in the loop in your own code where you iterate over the InputDevice instance.

@zeth
Copy link
Owner

zeth commented Dec 17, 2020

This is not the right way to fix this, IMO. The sleep does not belong in the _do_iter method. Just put in the loop in your own code where you iterate over the InputDevice instance.

This is what I thought. At least we should use asyncio or something so the user has control.

The original platform this was aimed at was Raspberry Pi then I tested it on Linux, Mac and Windows on thirty input devices.

(BTW If the delay is really needed on Windows then any solutions should only be on Windows, which to be fair I think this is. I don't feel I know enough yet to make changes.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants