-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: restore docs/cli/zetacored/cli.md
and improve file generation action
#3397
Conversation
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe pull request modifies the GitHub Actions workflow file Changes
Assessment against linked issues
Suggested reviewers
The modifications enhance the workflow's change detection capabilities, providing a more robust mechanism for identifying uncommitted file changes during the CI process. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
This reverts commit d0eedb0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/generate-files.yml
(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
.github/workflows/generate-files.yml
[error] 37-37: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: build-zetanode
- GitHub Check: build-and-test
- GitHub Check: lint
- GitHub Check: gosec
- GitHub Check: build
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
.github/workflows/generate-files.yml (1)
34-35
: Excellent improvement to change detection!The switch from
git diff
togit status --porcelain
is a robust enhancement that will now properly detect all types of changes, including file deletions. This directly addresses the issue mentioned in #3382.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3397 +/- ##
========================================
Coverage 63.40% 63.40%
========================================
Files 436 436
Lines 30690 30690
========================================
Hits 19460 19460
Misses 10394 10394
Partials 836 836 |
Description
Closes #3382
The file was removed in #2863.
This PR also adds a fix in the file generation action to detect file deletion for generate. CI fails if the file is not present.
Summary by CodeRabbit