Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): set github token for buf-setup-action #3366

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

gartnera
Copy link
Member

@gartnera gartnera commented Jan 16, 2025

Set token to avoid rate limiting. Closes #3350

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow configuration to include GitHub token for authentication in Buf setup action.

@gartnera gartnera added the no-changelog Skip changelog CI check label Jan 16, 2025
@gartnera gartnera requested a review from a team as a code owner January 16, 2025 18:05
Copy link
Contributor

coderabbitai bot commented Jan 16, 2025

📝 Walkthrough

Walkthrough

The pull request addresses a GitHub Actions workflow configuration issue by adding a github_token input to the bufbuild/buf-setup-action. This modification aims to resolve rate limiting problems encountered during the CI process by providing authentication for API requests, specifically for downloading and setting up the Buf tool.

Changes

File Change Summary
.github/workflows/generate-files.yml Added github_token: ${{ github.token }} to the Buf setup action to enable authenticated API requests

Assessment against linked issues

Objective Addressed Explanation
Resolve Buf setup rate limiting [#3350]

Suggested Labels

ci

Suggested Reviewers

  • lumtis
  • julianrubino
  • kingpinXD

The modification directly addresses the rate limiting issue by supplying the GitHub token, which should provide increased API request limits and resolve the authentication-related errors observed in the previous CI runs.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ci Changes to CI pipeline or github actions label Jan 16, 2025
@gartnera gartnera changed the title fix(ci): set github token for setup-buf fix(ci): set github token for buf-setup-action Jan 16, 2025
@gartnera gartnera enabled auto-merge January 16, 2025 18:05
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/generate-files.yml (1)

16-17: LGTM! Consider adding a comment for future maintainers.

The addition of the GitHub token to prevent rate limiting is correct and follows best practices. The use of the default github.token is appropriate for this use case.

Consider adding a brief comment explaining why the token is needed:

 - uses: bufbuild/buf-setup-action@v1
   with:
+    # Prevent rate limiting when downloading buf tool
     github_token: ${{ github.token }}
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7eea20e and b899cf9.

📒 Files selected for processing (1)
  • .github/workflows/generate-files.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: build-and-test
  • GitHub Check: build-zetanode
  • GitHub Check: lint
  • GitHub Check: gosec
  • GitHub Check: build
  • GitHub Check: Analyze (go)

@gartnera gartnera added this pull request to the merge queue Jan 17, 2025
auto-merge was automatically disabled January 17, 2025 16:57

Pull Request is not mergeable

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@gartnera gartnera added this pull request to the merge queue Jan 17, 2025
Merged via the queue into develop with commit 0d45918 Jan 17, 2025
45 of 49 checks passed
@gartnera gartnera deleted the setup-buf-rate-limited branch January 17, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI pipeline or github actions no-changelog Skip changelog CI check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: buf setup rate limited
4 participants