Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrige la façon de récupérer la version de nvm #6688

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

philippemilink
Copy link
Member

Avec le commentaire dans le fichier .nvmrc, le script d'installation affichait :

% ./scripts/install_zds.sh +node
* [+node] installing nvm (v0.39.5) & node (v18
# needs to be also updated in .github/workflows/ci.yml) & yarn

Contrôle qualité

Exécuter :

./scripts/install_zds.sh +node

et constater que le message affiché n'est pas bizarre.

@coveralls
Copy link

coveralls commented Nov 17, 2024

Coverage Status

coverage: 89.2%. remained the same
when pulling 83f1e42 on philippemilink:fix-install-message
into 79a2033 on zestedesavoir:dev.

@philippemilink philippemilink added the C-DevelopmentEnv Amélioration de l'environnement de dev label Nov 17, 2024
Avec le commentaire dans le fichier .nvmrc, le script d'installation
affichait :
```
% ./scripts/install_zds.sh +node
* [+node] installing nvm (v0.39.5) & node (v18
# needs to be also updated in .github/workflows/ci.yml) & yarn
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-DevelopmentEnv Amélioration de l'environnement de dev
Projects
Status: En attente de QA
Development

Successfully merging this pull request may close these issues.

2 participants