Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Améliore l'accessibilité de l'avatar #6660

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Situphen
Copy link
Member

@Situphen Situphen commented Oct 7, 2024

Correction de l'accessibilité réduite par #6609

QA : Valider par une relecture du code que l'accessibilité est améliorée

@Situphen Situphen requested a review from AmauryCarrade October 7, 2024 21:32
@coveralls
Copy link

Coverage Status

coverage: 89.182%. remained the same
when pulling f7e30bd on Situphen:avatar-a11y
into 77c115d on zestedesavoir:dev.

Copy link
Member

@AmauryCarrade AmauryCarrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai vérifié tous les usages du tag avatar et il semble bien que pour tous, l'usage soit décoratif. Donc ça me va !

Je note au fil de ma revue que l'on pourrait masquer (aria-hidden) tout ce bloc qui ne contient que l’avatar, sur la page de profil. Mais c'est assez peu prioritaire pour ne pas nécessiter une PR juste pour ça.

<div class="avatar">
<figure>
{% avatar profile size=200 %}
</figure>
</div>

@AmauryCarrade AmauryCarrade merged commit 61665d3 into zestedesavoir:dev Oct 9, 2024
12 checks passed
@AmauryCarrade AmauryCarrade deleted the avatar-a11y branch October 9, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants