Supprime le champ inutile Comment.update_index_date #6659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppression du champ inutile
Comment.update_index_date
, devenu inutile depuis le passage à Typesense (il l'était peut-être même avant).Rechercher toutes les occurrences de
update_index_date
, m'a fait découvrir qu'on déclenche une sauvegarde du Topic lorsqu'on édite un Post (ce qui crée un CommentEdit) pour marquer le Topic comme à réindexer, ce qui n'est pas (plus) nécessaire (cf mon commentaire dans le message de commit). J'en ai profité pour ajouter un petit test.Contrôle qualité
Juste regarder le code et la CI.