logging: fs backend: only fs_sync when done with a batch of logs #84979
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous behavior was to call `fs_sync` on the file after every log item written. In many cases, log messages come in bursts, and `log_core` already operates in batches, configurable using `CONFIG_LOG_PROCESS_THREAD_SLEEP_MS` and `CONFIG_LOG_PROCESS_TRIGGER_THRESHOLD`. Once the batch is done, the backends get notified with `LOG_BACKEND_EVT_PROCESS_THREAD_DONE` if any logs were processed. This is a nice time to `fs_sync` the written changes. This change both speeds up the time spent writing logs and reduces the amount of block erases done on the flash, as the previous implementation erased blocks after each individual log message. Signed-off-by: Kamil Krzyzanowski <[email protected]>
kamnxt
force-pushed
the
log_backend_fs_sync
branch
from
c406520 to
fa58fe2
Compare
|
(I realize this is going to require some changes to the tests. Not sure what the best way forward is there?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior was to call
fs_syncon the file after every log item written. In many cases, log messages come in bursts, andlog_corealready operates in batches, configurable usingCONFIG_LOG_PROCESS_THREAD_SLEEP_MSandCONFIG_LOG_PROCESS_TRIGGER_THRESHOLD. Once the batch is done, the backends get notified withLOG_BACKEND_EVT_PROCESS_THREAD_DONEif any logs were processed. This is a nice time tofs_syncthe written changes.This change both speeds up the time spent writing logs and reduces the amount of block erases done on the flash, as the previous implementation erased blocks after each individual log message.