drivers: timer: Improve the accuracy of the MCUX OS Timer #84938
+30
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mmahadevan108
commented
Jan 30, 2025
mmahadevan108
commented
- The sys_clock_idle_exit function could be invoked multiple times. Hence add code so that is counter is stopped and the OS Timer is initialized once.
- Reset the OS Timer when exiting low power modes where the OS Timer loses its state
- Improve the cycles conversion algorithm
1. The sys_clock_idle_exit function could be invoked multiple times. Hence add code so that is counter is stopped and the OS Timer is initialized once. 2. Reset the OS Timer when exiting low power modes where the OS Timer loses its state 3. Improve the cycles conversion algorithm Signed-off-by: Mahesh Mahadevan <[email protected]>
zephyrbot
added
area: Timer
decsny
requested changes
Jan 31, 2025
Comment on lines
+120
to
+124
| /* Counter is set to wakeup the system after the requested time */ | ||
| if (counter_start(counter_dev) != 0) { | ||
| ret = 1; | ||
| } | ||
| counter_running = true; |
There was a problem hiding this comment.
if counter_start fails, shouldn't counter_running be set to false ?
Comment on lines
-89
to
-90
|
|
||
| timeout = k_ticks_to_us_ceil32(curr_timeout); |
There was a problem hiding this comment.
why this change from ceil to near ? can it be in the commit message
Comment on lines
-120
to
-124
|
|
||
| /* Counter is set to wakeup the system after the requested time */ | ||
| if (counter_start(counter_dev) != 0) { | ||
| ret = 1; | ||
| } |
There was a problem hiding this comment.
why is this moved before getting the timer value ? I didn't understand from the commit message
| mcux_lpc_ostick_isr(NULL); | ||
| /* Announce the time slept to the kernel*/ | ||
| mcux_lpc_ostick_isr(NULL); | ||
| } | ||
| } else { | ||
| ret = 1; | ||
| } |
There was a problem hiding this comment.
this whole function is confusing to read, it can be cleaned up by inverting the conditionals, like
if (!counter_dev) {
return 1;
}
if (!counter_running) {
return 0;
}
/* rest of the code */
return 0;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.