zbus: assert when inside an ISR and time out is not zero #84162
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigopex
requested changes
Jan 17, 2025
Currently various zbus functions silently change the timeout to zero when inside an ISR. If a developer is not aware of this it could lead to unexpected behaviour or a publish/read failing. Also in the zbus docs it states to only use a timeout of zero when inside a ISR multiple times. Signed-off-by: Brandon Allen <[email protected]>
brandon-exact
force-pushed
the
zbus-assert
branch
from
49755f8 to
b1a49d4
Compare
rodrigopex
approved these changes
Jan 17, 2025
|
@brandon-exact , thanks for the contribution 🎉 🎉 🎉! I am glad to see new faces helping out zbus and Zephyr. |
pdgendt
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently various zbus functions silently change the timeout
to zero when inside an ISR. If a developer is not aware
of this it could lead to unexpected behaviour or a
publish/read/notify failing.
Also in the zbus docs it states to only use a timeout of
zero when inside a ISR multiple times.